summaryrefslogtreecommitdiff
path: root/spec/graphql/resolvers/project_resolver_spec.rb
diff options
context:
space:
mode:
authorJan Provaznik <jprovaznik@gitlab.com>2019-05-06 21:24:19 +0000
committerAsh McKenzie <amckenzie@gitlab.com>2019-05-06 21:24:19 +0000
commit5ee7884d91c4513e1b7322a4ca30a2c908e931b8 (patch)
tree105fad94e4647ee63cda729192f7fff7e3f0b396 /spec/graphql/resolvers/project_resolver_spec.rb
parent863f2bcfb6ef7c6d3ce5726fa1a602e12f05ef57 (diff)
downloadgitlab-ce-5ee7884d91c4513e1b7322a4ca30a2c908e931b8.tar.gz
GraphQL - Add extra complexity for resolvers
If a field is a resolver, its complexity is automatically increased. By default we add extra points for sort and search arguments (which will be common for various resolvers). For specific resolvers we add field-specific complexity, e.g. for Issues complexity is increased if we filter issues by `labelName` (because then SQL query is more complex). We may want to tune these values in future depending on real-life results. Complexity is also dependent on the number of loaded nodes, but only if we don't search by specific ID(s). Also added complexity is limited (by default only twice more than child complexity) - the reason is that although it's more complex to process more items, the complexity increase is not linear (there is not so much difference between loading 10, 20 or 100 records from DB).
Diffstat (limited to 'spec/graphql/resolvers/project_resolver_spec.rb')
-rw-r--r--spec/graphql/resolvers/project_resolver_spec.rb8
1 files changed, 8 insertions, 0 deletions
diff --git a/spec/graphql/resolvers/project_resolver_spec.rb b/spec/graphql/resolvers/project_resolver_spec.rb
index d4990c6492c..4fdbb3aa43e 100644
--- a/spec/graphql/resolvers/project_resolver_spec.rb
+++ b/spec/graphql/resolvers/project_resolver_spec.rb
@@ -26,6 +26,14 @@ describe Resolvers::ProjectResolver do
end
end
+ it 'does not increase complexity depending on number of load limits' do
+ field1 = Types::BaseField.new(name: 'test', type: GraphQL::STRING_TYPE, resolver_class: described_class, null: false, max_page_size: 100)
+ field2 = Types::BaseField.new(name: 'test', type: GraphQL::STRING_TYPE, resolver_class: described_class, null: false, max_page_size: 1)
+
+ expect(field1.to_graphql.complexity.call({}, {}, 1)).to eq 2
+ expect(field2.to_graphql.complexity.call({}, {}, 1)).to eq 2
+ end
+
def resolve_project(full_path)
resolve(described_class, args: { full_path: full_path })
end