diff options
| author | TM Lee <tm89lee@gmail.com> | 2017-03-02 14:01:02 +0800 |
|---|---|---|
| committer | Rémy Coutable <remy@rymai.me> | 2017-12-11 18:30:56 +0100 |
| commit | 2cf3fc18a6e111a820f9842bb1d939790e8625eb (patch) | |
| tree | 5ebad1908460ef6bbdbab371373bd0705372218e /spec/helpers | |
| parent | bd8b6518855bd9768ca5d245467b5ff0934e40b6 (diff) | |
| download | gitlab-ce-2cf3fc18a6e111a820f9842bb1d939790e8625eb.tar.gz | |
Refactor member view by using presenter
- Create MemberPresenter alongside with GroupMemberPresenter and ProjectMemberPresenter
- Make Member model Presentable
- Move action_member_permission from MembersHelper into the MemberPresenter
- Added rspec using double, separate specs for GroupMemberPresenter and ProjectMemberPresenter
Fixes #28004.
Signed-off-by: Rémy Coutable <remy@rymai.me>
Diffstat (limited to 'spec/helpers')
| -rw-r--r-- | spec/helpers/members_helper_spec.rb | 8 |
1 files changed, 0 insertions, 8 deletions
diff --git a/spec/helpers/members_helper_spec.rb b/spec/helpers/members_helper_spec.rb index 33186cf50d5..45ffbeb27a4 100644 --- a/spec/helpers/members_helper_spec.rb +++ b/spec/helpers/members_helper_spec.rb @@ -1,14 +1,6 @@ require 'spec_helper' describe MembersHelper do - describe '#action_member_permission' do - let(:project_member) { build(:project_member) } - let(:group_member) { build(:group_member) } - - it { expect(action_member_permission(:admin, project_member)).to eq :admin_project_member } - it { expect(action_member_permission(:admin, group_member)).to eq :admin_group_member } - end - describe '#remove_member_message' do let(:requester) { create(:user) } let(:project) { create(:project, :public, :access_requestable) } |