diff options
| author | Brett Walker <bwalker@gitlab.com> | 2019-01-11 18:31:00 -0600 |
|---|---|---|
| committer | Brett Walker <bwalker@gitlab.com> | 2019-01-21 15:07:40 -0600 |
| commit | 7bc0fbe22f0dd2c96b596b591ef5dbf3eaae8dd3 (patch) | |
| tree | e59cc0f740c8511a58d057f16864f9cf661cd8ec /spec/helpers | |
| parent | 45a04f93747a128588268395071f00d0af70acd7 (diff) | |
| download | gitlab-ce-7bc0fbe22f0dd2c96b596b591ef5dbf3eaae8dd3.tar.gz | |
Fix review comments
including refactoring, disabling sourcepos for pipelines that
don't need it, and minimizing spec changes by disabling
sourcepos when not testing for it explicitly.
Diffstat (limited to 'spec/helpers')
| -rw-r--r-- | spec/helpers/issuables_helper_spec.rb | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/spec/helpers/issuables_helper_spec.rb b/spec/helpers/issuables_helper_spec.rb index 963d3029830..a0fb3641899 100644 --- a/spec/helpers/issuables_helper_spec.rb +++ b/spec/helpers/issuables_helper_spec.rb @@ -173,6 +173,7 @@ describe IssuablesHelper do before do allow(helper).to receive(:current_user).and_return(user) allow(helper).to receive(:can?).and_return(true) + stub_commonmark_sourcepos_disabled end it 'returns the correct json for an issue' do @@ -193,7 +194,7 @@ describe IssuablesHelper do projectNamespace: @project.namespace.path, initialTitleHtml: issue.title, initialTitleText: issue.title, - initialDescriptionHtml: '<p data-sourcepos="1:1-1:10" dir="auto">issue text</p>', + initialDescriptionHtml: '<p dir="auto">issue text</p>', initialDescriptionText: 'issue text', initialTaskStatus: '0 of 0 tasks completed' } |