Made diff & note data consistent

This caused many pain points when working with it.
Part of the data was camel cased the other snake case.
Other parts where snake case & then getting converted in components,
this conversion has the potential for leaking memory.

This changes that & makes it consistent with what it returned from the
API, snake case.

1 files changed, 1 insertions, 1 deletions

diff --git a/spec/javascripts/diffs/components/commit_widget_spec.js b/spec/javascripts/diffs/components/commit_widget_spec.js
index 951eb57255d..2b60bd232ed 100644
--- a/spec/javascripts/diffs/components/commit_widget_spec.js
+++ b/spec/javascripts/diffs/components/commit_widget_spec.js
@@ -19,6 +19,6 @@ describe('diffs/components/commit_widget', () => {
     const commitElement = vm.$el.querySelector('li.commit');
 
     expect(commitElement).not.toBeNull();
-    expect(commitElement).toContainText(commit.shortId);
+    expect(commitElement).toContainText(commit.short_id);
   });
 });