Made diff & note data consistent

This caused many pain points when working with it.
Part of the data was camel cased the other snake case.
Other parts where snake case & then getting converted in components,
this conversion has the potential for leaking memory.

This changes that & makes it consistent with what it returned from the
API, snake case.

2 files changed, 120 insertions, 122 deletions

diff --git a/spec/javascripts/diffs/mock_data/diff_file.js b/spec/javascripts/diffs/mock_data/diff_file.js
index be194ab414f..031c9842f2f 100644
--- a/spec/javascripts/diffs/mock_data/diff_file.js
+++ b/spec/javascripts/diffs/mock_data/diff_file.js
@@ -1,130 +1,130 @@
 export default {
   submodule: false,
-  submoduleLink: null,
+  submodule_link: null,
   blob: {
     id: '9e10516ca50788acf18c518a231914a21e5f16f7',
     path: 'CHANGELOG',
     name: 'CHANGELOG',
     mode: '100644',
-    readableText: true,
+    readable_text: true,
     icon: 'file-text-o',
   },
-  blobPath: 'CHANGELOG',
-  blobName: 'CHANGELOG',
-  blobIcon: '<i aria-hidden="true" data-hidden="true" class="fa fa-file-text-o fa-fw"></i>',
-  fileHash: '1c497fbb3a46b78edf04cc2a2fa33f67e3ffbe2a',
-  filePath: 'CHANGELOG',
-  newFile: false,
-  deletedFile: false,
-  renamedFile: false,
-  oldPath: 'CHANGELOG',
-  newPath: 'CHANGELOG',
-  modeChanged: false,
-  aMode: '100644',
-  bMode: '100644',
+  blob_path: 'CHANGELOG',
+  blob_name: 'CHANGELOG',
+  blob_icon: '<i aria-hidden="true" data-hidden="true" class="fa fa-file-text-o fa-fw"></i>',
+  file_hash: '1c497fbb3a46b78edf04cc2a2fa33f67e3ffbe2a',
+  file_path: 'CHANGELOG',
+  new_file: false,
+  deleted_file: false,
+  renamed_file: false,
+  old_path: 'CHANGELOG',
+  new_path: 'CHANGELOG',
+  mode_changed: false,
+  a_mode: '100644',
+  b_mode: '100644',
   text: true,
   viewer: {
     name: 'text',
   },
-  addedLines: 2,
-  removedLines: 0,
-  diffRefs: {
-    baseSha: 'e63f41fe459e62e1228fcef60d7189127aeba95a',
-    startSha: 'd9eaefe5a676b820c57ff18cf5b68316025f7962',
-    headSha: 'c48ee0d1bf3b30453f5b32250ce03134beaa6d13',
+  added_lines: 2,
+  removed_lines: 0,
+  diff_refs: {
+    base_sha: 'e63f41fe459e62e1228fcef60d7189127aeba95a',
+    start_sha: 'd9eaefe5a676b820c57ff18cf5b68316025f7962',
+    head_sha: 'c48ee0d1bf3b30453f5b32250ce03134beaa6d13',
   },
-  contentSha: 'c48ee0d1bf3b30453f5b32250ce03134beaa6d13',
-  storedExternally: null,
-  externalStorage: null,
-  oldPathHtml: 'CHANGELOG',
-  newPathHtml: 'CHANGELOG',
-  editPath: '/gitlab-org/gitlab-test/edit/spooky-stuff/CHANGELOG',
-  viewPath: '/gitlab-org/gitlab-test/blob/spooky-stuff/CHANGELOG',
-  replacedViewPath: null,
+  content_sha: 'c48ee0d1bf3b30453f5b32250ce03134beaa6d13',
+  stored_externally: null,
+  external_storage: null,
+  old_path_html: 'CHANGELOG',
+  new_path_html: 'CHANGELOG',
+  edit_path: '/gitlab-org/gitlab-test/edit/spooky-stuff/CHANGELOG',
+  view_path: '/gitlab-org/gitlab-test/blob/spooky-stuff/CHANGELOG',
+  replaced_view_path: null,
   collapsed: false,
   renderIt: false,
-  tooLarge: false,
-  contextLinesPath:
+  too_large: false,
+  context_lines_path:
     '/gitlab-org/gitlab-test/blob/c48ee0d1bf3b30453f5b32250ce03134beaa6d13/CHANGELOG/diff',
-  highlightedDiffLines: [
+  highlighted_diff_lines: [
     {
-      lineCode: '1c497fbb3a46b78edf04cc2a2fa33f67e3ffbe2a_1_1',
+      line_code: '1c497fbb3a46b78edf04cc2a2fa33f67e3ffbe2a_1_1',
       type: 'new',
-      oldLine: null,
-      newLine: 1,
+      old_line: null,
+      new_line: 1,
       discussions: [],
       text: '+<span id="LC1" class="line" lang="plaintext">  - Bad dates</span>\n',
-      richText: '+<span id="LC1" class="line" lang="plaintext">  - Bad dates</span>\n',
-      metaData: null,
+      rich_text: '+<span id="LC1" class="line" lang="plaintext">  - Bad dates</span>\n',
+      meta_data: null,
     },
     {
-      lineCode: '1c497fbb3a46b78edf04cc2a2fa33f67e3ffbe2a_1_2',
+      line_code: '1c497fbb3a46b78edf04cc2a2fa33f67e3ffbe2a_1_2',
       type: 'new',
-      oldLine: null,
-      newLine: 2,
+      old_line: null,
+      new_line: 2,
       discussions: [],
       text: '+<span id="LC2" class="line" lang="plaintext"></span>\n',
-      richText: '+<span id="LC2" class="line" lang="plaintext"></span>\n',
-      metaData: null,
+      rich_text: '+<span id="LC2" class="line" lang="plaintext"></span>\n',
+      meta_data: null,
     },
     {
-      lineCode: '1c497fbb3a46b78edf04cc2a2fa33f67e3ffbe2a_1_3',
+      line_code: '1c497fbb3a46b78edf04cc2a2fa33f67e3ffbe2a_1_3',
       type: null,
-      oldLine: 1,
-      newLine: 3,
+      old_line: 1,
+      new_line: 3,
       discussions: [],
       text: ' <span id="LC3" class="line" lang="plaintext">v6.8.0</span>\n',
-      richText: ' <span id="LC3" class="line" lang="plaintext">v6.8.0</span>\n',
-      metaData: null,
+      rich_text: ' <span id="LC3" class="line" lang="plaintext">v6.8.0</span>\n',
+      meta_data: null,
     },
     {
-      lineCode: '1c497fbb3a46b78edf04cc2a2fa33f67e3ffbe2a_2_4',
+      line_code: '1c497fbb3a46b78edf04cc2a2fa33f67e3ffbe2a_2_4',
       type: null,
-      oldLine: 2,
-      newLine: 4,
+      old_line: 2,
+      new_line: 4,
       discussions: [],
       text: ' <span id="LC4" class="line" lang="plaintext"></span>\n',
-      richText: ' <span id="LC4" class="line" lang="plaintext"></span>\n',
-      metaData: null,
+      rich_text: ' <span id="LC4" class="line" lang="plaintext"></span>\n',
+      meta_data: null,
     },
     {
-      lineCode: '1c497fbb3a46b78edf04cc2a2fa33f67e3ffbe2a_3_5',
+      line_code: '1c497fbb3a46b78edf04cc2a2fa33f67e3ffbe2a_3_5',
       type: null,
-      oldLine: 3,
-      newLine: 5,
+      old_line: 3,
+      new_line: 5,
       discussions: [],
       text: ' <span id="LC5" class="line" lang="plaintext">v6.7.0</span>\n',
-      richText: ' <span id="LC5" class="line" lang="plaintext">v6.7.0</span>\n',
-      metaData: null,
+      rich_text: ' <span id="LC5" class="line" lang="plaintext">v6.7.0</span>\n',
+      meta_data: null,
     },
     {
-      lineCode: null,
+      line_code: null,
       type: 'match',
-      oldLine: null,
-      newLine: null,
+      old_line: null,
+      new_line: null,
       discussions: [],
       text: '',
-      richText: '',
-      metaData: {
-        oldPos: 3,
-        newPos: 5,
+      rich_text: '',
+      meta_data: {
+        old_pos: 3,
+        new_pos: 5,
       },
     },
   ],
-  parallelDiffLines: [
+  parallel_diff_lines: [
     {
       left: {
         type: 'empty-cell',
       },
       right: {
-        lineCode: '1c497fbb3a46b78edf04cc2a2fa33f67e3ffbe2a_1_1',
+        line_code: '1c497fbb3a46b78edf04cc2a2fa33f67e3ffbe2a_1_1',
         type: 'new',
-        oldLine: null,
-        newLine: 1,
+        old_line: null,
+        new_line: 1,
         discussions: [],
         text: '+<span id="LC1" class="line" lang="plaintext">  - Bad dates</span>\n',
-        richText: '<span id="LC1" class="line" lang="plaintext">  - Bad dates</span>\n',
-        metaData: null,
+        rich_text: '<span id="LC1" class="line" lang="plaintext">  - Bad dates</span>\n',
+        meta_data: null,
       },
     },
     {
@@ -132,107 +132,107 @@ export default {
         type: 'empty-cell',
       },
       right: {
-        lineCode: '1c497fbb3a46b78edf04cc2a2fa33f67e3ffbe2a_1_2',
+        line_code: '1c497fbb3a46b78edf04cc2a2fa33f67e3ffbe2a_1_2',
         type: 'new',
-        oldLine: null,
-        newLine: 2,
+        old_line: null,
+        new_line: 2,
         discussions: [],
         text: '+<span id="LC2" class="line" lang="plaintext"></span>\n',
-        richText: '<span id="LC2" class="line" lang="plaintext"></span>\n',
-        metaData: null,
+        rich_text: '<span id="LC2" class="line" lang="plaintext"></span>\n',
+        meta_data: null,
       },
     },
     {
       left: {
-        lineCode: '1c497fbb3a46b78edf04cc2a2fa33f67e3ffbe2a_1_3',
+        line_Code: '1c497fbb3a46b78edf04cc2a2fa33f67e3ffbe2a_1_3',
         type: null,
-        oldLine: 1,
-        newLine: 3,
+        old_line: 1,
+        new_line: 3,
         discussions: [],
         text: ' <span id="LC3" class="line" lang="plaintext">v6.8.0</span>\n',
-        richText: '<span id="LC3" class="line" lang="plaintext">v6.8.0</span>\n',
-        metaData: null,
+        rich_text: '<span id="LC3" class="line" lang="plaintext">v6.8.0</span>\n',
+        meta_data: null,
       },
       right: {
-        lineCode: '1c497fbb3a46b78edf04cc2a2fa33f67e3ffbe2a_1_3',
+        line_code: '1c497fbb3a46b78edf04cc2a2fa33f67e3ffbe2a_1_3',
         type: null,
-        oldLine: 1,
-        newLine: 3,
+        old_line: 1,
+        new_line: 3,
         discussions: [],
         text: ' <span id="LC3" class="line" lang="plaintext">v6.8.0</span>\n',
-        richText: '<span id="LC3" class="line" lang="plaintext">v6.8.0</span>\n',
-        metaData: null,
+        rich_text: '<span id="LC3" class="line" lang="plaintext">v6.8.0</span>\n',
+        meta_data: null,
       },
     },
     {
       left: {
-        lineCode: '1c497fbb3a46b78edf04cc2a2fa33f67e3ffbe2a_2_4',
+        line_code: '1c497fbb3a46b78edf04cc2a2fa33f67e3ffbe2a_2_4',
         type: null,
-        oldLine: 2,
-        newLine: 4,
+        old_line: 2,
+        new_line: 4,
         discussions: [],
         text: ' <span id="LC4" class="line" lang="plaintext"></span>\n',
-        richText: '<span id="LC4" class="line" lang="plaintext"></span>\n',
-        metaData: null,
+        rich_text: '<span id="LC4" class="line" lang="plaintext"></span>\n',
+        meta_data: null,
       },
       right: {
-        lineCode: '1c497fbb3a46b78edf04cc2a2fa33f67e3ffbe2a_2_4',
+        line_code: '1c497fbb3a46b78edf04cc2a2fa33f67e3ffbe2a_2_4',
         type: null,
-        oldLine: 2,
-        newLine: 4,
+        old_line: 2,
+        new_line: 4,
         discussions: [],
         text: ' <span id="LC4" class="line" lang="plaintext"></span>\n',
-        richText: '<span id="LC4" class="line" lang="plaintext"></span>\n',
-        metaData: null,
+        rich_text: '<span id="LC4" class="line" lang="plaintext"></span>\n',
+        meta_data: null,
       },
     },
     {
       left: {
-        lineCode: '1c497fbb3a46b78edf04cc2a2fa33f67e3ffbe2a_3_5',
+        line_code: '1c497fbb3a46b78edf04cc2a2fa33f67e3ffbe2a_3_5',
         type: null,
-        oldLine: 3,
-        newLine: 5,
+        old_line: 3,
+        new_line: 5,
         discussions: [],
         text: ' <span id="LC5" class="line" lang="plaintext">v6.7.0</span>\n',
-        richText: '<span id="LC5" class="line" lang="plaintext">v6.7.0</span>\n',
-        metaData: null,
+        rich_text: '<span id="LC5" class="line" lang="plaintext">v6.7.0</span>\n',
+        meta_data: null,
       },
       right: {
-        lineCode: '1c497fbb3a46b78edf04cc2a2fa33f67e3ffbe2a_3_5',
+        line_code: '1c497fbb3a46b78edf04cc2a2fa33f67e3ffbe2a_3_5',
         type: null,
-        oldLine: 3,
-        newLine: 5,
+        old_line: 3,
+        new_line: 5,
         discussions: [],
         text: ' <span id="LC5" class="line" lang="plaintext">v6.7.0</span>\n',
-        richText: '<span id="LC5" class="line" lang="plaintext">v6.7.0</span>\n',
-        metaData: null,
+        rich_text: '<span id="LC5" class="line" lang="plaintext">v6.7.0</span>\n',
+        meta_data: null,
       },
     },
     {
       left: {
-        lineCode: null,
+        line_code: null,
         type: 'match',
-        oldLine: null,
-        newLine: null,
+        old_line: null,
+        new_line: null,
         discussions: [],
         text: '',
-        richText: '',
-        metaData: {
-          oldPos: 3,
-          newPos: 5,
+        rich_text: '',
+        meta_data: {
+          old_pos: 3,
+          new_pos: 5,
         },
       },
       right: {
-        lineCode: null,
+        line_code: null,
         type: 'match',
-        oldLine: null,
-        newLine: null,
+        old_line: null,
+        new_line: null,
         discussions: [],
         text: '',
-        richText: '',
-        metaData: {
-          oldPos: 3,
-          newPos: 5,
+        rich_text: '',
+        meta_data: {
+          old_pos: 3,
+          new_pos: 5,
         },
       },
     },
diff --git a/spec/javascripts/diffs/mock_data/diff_with_commit.js b/spec/javascripts/diffs/mock_data/diff_with_commit.js
index bee04fa4932..d646294ee84 100644
--- a/spec/javascripts/diffs/mock_data/diff_with_commit.js
+++ b/spec/javascripts/diffs/mock_data/diff_with_commit.js
@@ -1,9 +1,7 @@
-import { convertObjectPropsToCamelCase } from '~/lib/utils/common_utils';
-
 const FIXTURE = 'merge_request_diffs/with_commit.json';
 
 preloadFixtures(FIXTURE);
 
 export default function getDiffWithCommit() {
-  return convertObjectPropsToCamelCase(getJSONFixture(FIXTURE), { deep: true });
+  return getJSONFixture(FIXTURE);
 }