diff options
author | Jacob Schatz <jschatz@gitlab.com> | 2017-06-20 19:31:02 +0000 |
---|---|---|
committer | Jacob Schatz <jschatz@gitlab.com> | 2017-06-20 19:31:02 +0000 |
commit | b2e1d32e7a74b22b23e8ab052bd29e15bb8a4f1e (patch) | |
tree | 79b712d3b8e8cefe4b758348209b4270e5886e86 /spec/javascripts/fixtures | |
parent | 780adff549a48b6c4d0ba77725b4027b0616178f (diff) | |
parent | f7ad9e5abbfd0916a4f93e22d97cbdac17c46986 (diff) | |
download | gitlab-ce-b2e1d32e7a74b22b23e8ab052bd29e15bb8a4f1e.tar.gz |
Merge branch '33868-fix-mr-changes-diff-note-up-arrow-editing' into 'master'34013-names-with-spaces-break-issue-filter-bar
Fix pressing up-arrow on a MR "Changes" diff discussion edits your last note
Closes #33868
See merge request !12297
Diffstat (limited to 'spec/javascripts/fixtures')
-rw-r--r-- | spec/javascripts/fixtures/merge_requests.rb | 13 |
1 files changed, 10 insertions, 3 deletions
diff --git a/spec/javascripts/fixtures/merge_requests.rb b/spec/javascripts/fixtures/merge_requests.rb index a746a776548..0715f4d5f6b 100644 --- a/spec/javascripts/fixtures/merge_requests.rb +++ b/spec/javascripts/fixtures/merge_requests.rb @@ -55,13 +55,20 @@ describe Projects::MergeRequestsController, '(JavaScript fixtures)', type: :cont render_merge_request(example.description, merge_request) end + it 'merge_requests/changes_tab_with_comments.json' do |example| + create(:diff_note_on_merge_request, project: project, author: admin, position: position, noteable: merge_request) + create(:note_on_merge_request, author: admin, project: project, noteable: merge_request) + render_merge_request(example.description, merge_request, action: :diffs, format: :json) + end + private - def render_merge_request(fixture_file_name, merge_request) - get :show, + def render_merge_request(fixture_file_name, merge_request, action: :show, format: :html) + get action, namespace_id: project.namespace.to_param, project_id: project, - id: merge_request.to_param + id: merge_request.to_param, + format: format expect(response).to be_success store_frontend_fixture(response, fixture_file_name) |