diff options
author | Paul Slaughter <pslaughter@gitlab.com> | 2018-09-27 16:57:30 -0500 |
---|---|---|
committer | Paul Slaughter <pslaughter@gitlab.com> | 2018-09-28 15:03:39 -0500 |
commit | adbf6149cf1778cd48a9bbf8e97332669dbcb7cb (patch) | |
tree | 01f53873bc7dbe0b04d8de8182af359e21ecc2b4 /spec/javascripts/ide/components/ide_status_bar_spec.js | |
parent | 1eefdf5da50030fbc342a08155ed4aa56805aea9 (diff) | |
download | gitlab-ce-adbf6149cf1778cd48a9bbf8e97332669dbcb7cb.tar.gz |
Keep IDE RightPane views aliveide-keep-right-pane-tabs-alive
**Why?**
- This is needed for the Web Terminal feature.
https://gitlab.com/gitlab-org/gitlab-ee/issues/5426
**Notes:**
- Introduces a `pane` Vuex module.
- Some views should not be kept alive (i.e. job details).
This is why a `keepAlive` flag was introduced for views.
Diffstat (limited to 'spec/javascripts/ide/components/ide_status_bar_spec.js')
-rw-r--r-- | spec/javascripts/ide/components/ide_status_bar_spec.js | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/spec/javascripts/ide/components/ide_status_bar_spec.js b/spec/javascripts/ide/components/ide_status_bar_spec.js index 0e93c5193a1..47d6492a7a6 100644 --- a/spec/javascripts/ide/components/ide_status_bar_spec.js +++ b/spec/javascripts/ide/components/ide_status_bar_spec.js @@ -1,6 +1,7 @@ import Vue from 'vue'; import store from '~/ide/stores'; import ideStatusBar from '~/ide/components/ide_status_bar.vue'; +import { rightSidebarViews } from '~/ide/constants'; import { createComponentWithStore } from 'spec/helpers/vue_mount_component_helper'; import { resetStore } from '../helpers'; import { projectData } from '../mock_data'; @@ -64,7 +65,7 @@ describe('ideStatusBar', () => { describe('pipeline status', () => { it('opens right sidebar on clicking icon', done => { - spyOn(vm, 'setRightPane'); + spyOn(vm, 'openRightPane'); Vue.set(vm.$store.state.pipelines, 'latestPipeline', { details: { status: { @@ -80,7 +81,7 @@ describe('ideStatusBar', () => { .then(() => { vm.$el.querySelector('.ide-status-pipeline button').click(); - expect(vm.setRightPane).toHaveBeenCalledWith('pipelines-list'); + expect(vm.openRightPane).toHaveBeenCalledWith(rightSidebarViews.pipelines); }) .then(done) .catch(done.fail); |