Fix comment on image discussion icon alignment39608-comment-on-image-discussions-tab-alignment

Fix https://gitlab.com/gitlab-org/gitlab-ce/issues/39608

Use SVG icons to avoid having to position things
See https://gitlab.com/gitlab-org/gitlab-ce/issues/39608#note_50088917

1 files changed, 1 insertions, 8 deletions

diff --git a/spec/javascripts/image_diff/helpers/badge_helper_spec.js b/spec/javascripts/image_diff/helpers/badge_helper_spec.js
index fb9c7e59031..ce3add1fd90 100644
--- a/spec/javascripts/image_diff/helpers/badge_helper_spec.js
+++ b/spec/javascripts/image_diff/helpers/badge_helper_spec.js
@@ -89,15 +89,8 @@ describe('badge helper', () => {
     });
 
     it('should create icon comment button', () => {
-      const iconEl = buttonEl.querySelector('i');
+      const iconEl = buttonEl.querySelector('svg');
       expect(iconEl).toBeDefined();
-      expect(iconEl.classList.contains('fa')).toEqual(true);
-      expect(iconEl.classList.contains('fa-comment-o')).toEqual(true);
-    });
-
-    it('should have .image-comment-badge.inverted in button class', () => {
-      expect(buttonEl.classList.contains('image-comment-badge')).toEqual(true);
-      expect(buttonEl.classList.contains('inverted')).toEqual(true);
     });
   });