Revert "Merge branch 'winh-merge-request-related-issues' into 'master'"winh-revert-6ac777a7592533d9c7b3682b2b9ca8caccca3f4d

This reverts commit 6ac777a7592533d9c7b3682b2b9ca8caccca3f4d, reversing
changes made to 025cbc2ad4dc175634676ff8a6955e043512d8bf.

3 files changed, 77 insertions, 188 deletions

diff --git a/spec/javascripts/vue_mr_widget/components/mr_widget_related_links_spec.js b/spec/javascripts/vue_mr_widget/components/mr_widget_related_links_spec.js
index 6a44c54cdee..f6e0c3dfb74 100644
--- a/spec/javascripts/vue_mr_widget/components/mr_widget_related_links_spec.js
+++ b/spec/javascripts/vue_mr_widget/components/mr_widget_related_links_spec.js
@@ -1,31 +1,20 @@
 import Vue from 'vue';
-import MRWidgetRelatedLinks from '~/vue_merge_request_widget/components/mr_widget_related_links';
+import relatedLinksComponent from '~/vue_merge_request_widget/components/mr_widget_related_links';
 
-describe('MRWidgetRelatedLinks', () => {
-  let vm;
-
-  beforeEach(() => {
-    const Component = Vue.extend(MRWidgetRelatedLinks);
-    vm = new Component({
-      el: document.createElement('div'),
-      propsData: {
-        isMerged: false,
-        relatedLinks: {},
-      },
-    });
-  });
+const createComponent = (data) => {
+  const Component = Vue.extend(relatedLinksComponent);
 
-  afterEach(() => {
-    vm.$destroy();
+  return new Component({
+    el: document.createElement('div'),
+    propsData: data,
   });
+};
 
+describe('MRWidgetRelatedLinks', () => {
   describe('props', () => {
     it('should have props', () => {
-      const { isMerged, relatedLinks } = MRWidgetRelatedLinks.props;
+      const { relatedLinks } = relatedLinksComponent.props;
 
-      expect(isMerged).toBeDefined();
-      expect(isMerged.type).toBe(Boolean);
-      expect(isMerged.required).toBeTruthy();
       expect(relatedLinks).toBeDefined();
       expect(relatedLinks.type instanceof Object).toBeTruthy();
       expect(relatedLinks.required).toBeTruthy();
@@ -33,38 +22,16 @@ describe('MRWidgetRelatedLinks', () => {
   });
 
   describe('computed', () => {
-    describe('closingText', () => {
-      const dummyIssueLabel = 'dummy label';
-
-      beforeEach(() => {
-        spyOn(vm, 'issueLabel').and.returnValue(dummyIssueLabel);
-      });
-
-      it('outputs text for closing issues', () => {
-        vm.isMerged = false;
-
-        const text = vm.closingText;
-
-        expect(text).toBe(`Closes ${dummyIssueLabel}`);
-      });
-
-      it('outputs text for closed issues', () => {
-        vm.isMerged = true;
-
-        const text = vm.closingText;
-
-        expect(text).toBe(`Closed ${dummyIssueLabel}`);
-      });
-    });
-
     describe('hasLinks', () => {
       it('should return correct value when we have links reference', () => {
-        vm.relatedLinks = {
-          closing: '/foo',
-          mentioned: '/foo',
-          assignToMe: '/foo',
+        const data = {
+          relatedLinks: {
+            closing: '/foo',
+            mentioned: '/foo',
+            assignToMe: '/foo',
+          },
         };
-
+        const vm = createComponent(data);
         expect(vm.hasLinks).toBeTruthy();
 
         vm.relatedLinks.closing = null;
@@ -77,160 +44,95 @@ describe('MRWidgetRelatedLinks', () => {
         expect(vm.hasLinks).toBeFalsy();
       });
     });
-
-    describe('mentionedText', () => {
-      it('outputs text for one mentioned issue before merging', () => {
-        vm.isMerged = false;
-        spyOn(vm, 'hasMultipleIssues').and.returnValue(false);
-
-        const text = vm.mentionedText;
-
-        expect(text).toBe('is mentioned but will not be closed');
-      });
-
-      it('outputs text for one mentioned issue after merging', () => {
-        vm.isMerged = true;
-        spyOn(vm, 'hasMultipleIssues').and.returnValue(false);
-
-        const text = vm.mentionedText;
-
-        expect(text).toBe('is mentioned but was not closed');
-      });
-
-      it('outputs text for multiple mentioned issue before merging', () => {
-        vm.isMerged = false;
-        spyOn(vm, 'hasMultipleIssues').and.returnValue(true);
-
-        const text = vm.mentionedText;
-
-        expect(text).toBe('are mentioned but will not be closed');
-      });
-
-      it('outputs text for multiple mentioned issue after merging', () => {
-        vm.isMerged = true;
-        spyOn(vm, 'hasMultipleIssues').and.returnValue(true);
-
-        const text = vm.mentionedText;
-
-        expect(text).toBe('are mentioned but were not closed');
-      });
-    });
   });
 
   describe('methods', () => {
-    const relatedLinks = {
-      oneIssue: '<a href="#">#7</a>',
-      twoIssues: '<a href="#">#23</a> and <a>#42</a>',
-      threeIssues: '<a href="#">#1</a>, <a>#2</a>, and <a>#3</a>',
+    const data = {
+      relatedLinks: {
+        closing: '<a href="#">#23</a> and <a>#42</a>',
+        mentioned: '<a href="#">#7</a>',
+      },
     };
-
-    beforeEach(() => {
-      vm.relatedLinks = relatedLinks;
-    });
+    const vm = createComponent(data);
 
     describe('hasMultipleIssues', () => {
       it('should return true if the given text has multiple issues', () => {
-        expect(vm.hasMultipleIssues(relatedLinks.twoIssues)).toBeTruthy();
-        expect(vm.hasMultipleIssues(relatedLinks.threeIssues)).toBeTruthy();
+        expect(vm.hasMultipleIssues(data.relatedLinks.closing)).toBeTruthy();
       });
 
       it('should return false if the given text has one issue', () => {
-        expect(vm.hasMultipleIssues(relatedLinks.oneIssue)).toBeFalsy();
+        expect(vm.hasMultipleIssues(data.relatedLinks.mentioned)).toBeFalsy();
       });
     });
 
     describe('issueLabel', () => {
       it('should return true if the given text has multiple issues', () => {
-        expect(vm.issueLabel('twoIssues')).toEqual('issues');
-        expect(vm.issueLabel('threeIssues')).toEqual('issues');
+        expect(vm.issueLabel('closing')).toEqual('issues');
+      });
+
+      it('should return false if the given text has one issue', () => {
+        expect(vm.issueLabel('mentioned')).toEqual('issue');
+      });
+    });
+
+    describe('verbLabel', () => {
+      it('should return true if the given text has multiple issues', () => {
+        expect(vm.verbLabel('closing')).toEqual('are');
       });
 
       it('should return false if the given text has one issue', () => {
-        expect(vm.issueLabel('oneIssue')).toEqual('issue');
+        expect(vm.verbLabel('mentioned')).toEqual('is');
       });
     });
   });
 
   describe('template', () => {
-    it('should have only have closing issues text', (done) => {
-      vm.relatedLinks = {
-        closing: '<a href="#">#23</a> and <a>#42</a>',
-      };
-
-      Vue.nextTick()
-      .then(() => {
-        const content = vm.$el.textContent.replace(/\n(\s)+/g, ' ').trim();
+    it('should have only have closing issues text', () => {
+      const vm = createComponent({
+        relatedLinks: {
+          closing: '<a href="#">#23</a> and <a>#42</a>',
+        },
+      });
+      const content = vm.$el.textContent.replace(/\n(\s)+/g, ' ').trim();
 
-        expect(content).toContain('Closes issues #23 and #42');
-        expect(content).not.toContain('mentioned');
-      })
-      .then(done)
-      .catch(done.fail);
+      expect(content).toContain('Closes issues #23 and #42');
+      expect(content).not.toContain('mentioned');
     });
 
-    it('should have only have mentioned issues text', (done) => {
-      vm.relatedLinks = {
-        mentioned: '<a href="#">#7</a>',
-      };
-
-      Vue.nextTick()
-      .then(() => {
-        expect(vm.$el.innerText).toContain('issue #7');
-        expect(vm.$el.innerText).toContain('is mentioned but will not be closed');
-        expect(vm.$el.innerText).not.toContain('Closes');
-      })
-      .then(done)
-      .catch(done.fail);
-    });
+    it('should have only have mentioned issues text', () => {
+      const vm = createComponent({
+        relatedLinks: {
+          mentioned: '<a href="#">#7</a>',
+        },
+      });
 
-    it('should have closing and mentioned issues at the same time', (done) => {
-      vm.relatedLinks = {
-        closing: '<a href="#">#7</a>',
-        mentioned: '<a href="#">#23</a> and <a>#42</a>',
-      };
-
-      Vue.nextTick()
-      .then(() => {
-        const content = vm.$el.textContent.replace(/\n(\s)+/g, ' ').trim();
-
-        expect(content).toContain('Closes issue #7.');
-        expect(content).toContain('issues #23 and #42');
-        expect(content).toContain('are mentioned but will not be closed');
-      })
-      .then(done)
-      .catch(done.fail);
+      expect(vm.$el.innerText).toContain('issue #7');
+      expect(vm.$el.innerText).toContain('is mentioned but will not be closed.');
+      expect(vm.$el.innerText).not.toContain('Closes');
     });
 
-    it('should have assing issues link', (done) => {
-      vm.relatedLinks = {
-        assignToMe: '<a href="#">Assign yourself to these issues</a>',
-      };
-
-      Vue.nextTick()
-      .then(() => {
-        expect(vm.$el.innerText).toContain('Assign yourself to these issues');
-      })
-      .then(done)
-      .catch(done.fail);
+    it('should have closing and mentioned issues at the same time', () => {
+      const vm = createComponent({
+        relatedLinks: {
+          closing: '<a href="#">#7</a>',
+          mentioned: '<a href="#">#23</a> and <a>#42</a>',
+        },
+      });
+      const content = vm.$el.textContent.replace(/\n(\s)+/g, ' ').trim();
+
+      expect(content).toContain('Closes issue #7.');
+      expect(content).toContain('issues #23 and #42');
+      expect(content).toContain('are mentioned but will not be closed.');
     });
 
-    it('should use different wording after merging', (done) => {
-      vm.isMerged = true;
-      vm.relatedLinks = {
-        closing: '<a href="#">#7</a>',
-        mentioned: '<a href="#">#23</a> and <a>#42</a>',
-      };
-
-      Vue.nextTick()
-      .then(() => {
-        const content = vm.$el.textContent.replace(/\n(\s)+/g, ' ').trim();
-
-        expect(content).toContain('Closed issue #7.');
-        expect(content).toContain('issues #23 and #42');
-        expect(content).toContain('are mentioned but were not closed');
-      })
-      .then(done)
-      .catch(done.fail);
+    it('should have assing issues link', () => {
+      const vm = createComponent({
+        relatedLinks: {
+          assignToMe: '<a href="#">Assign yourself to these issues</a>',
+        },
+      });
+
+      expect(vm.$el.innerText).toContain('Assign yourself to these issues');
     });
   });
 });
diff --git a/spec/javascripts/vue_mr_widget/mr_widget_options_spec.js b/spec/javascripts/vue_mr_widget/mr_widget_options_spec.js
index 425dff89439..3a0c50b750f 100644
--- a/spec/javascripts/vue_mr_widget/mr_widget_options_spec.js
+++ b/spec/javascripts/vue_mr_widget/mr_widget_options_spec.js
@@ -48,13 +48,12 @@ describe('mrWidgetOptions', () => {
     });
 
     describe('shouldRenderMergeHelp', () => {
-      it('should return false after merging', () => {
-        vm.mr.isMerged = true;
+      it('should return false for the initial merged state', () => {
         expect(vm.shouldRenderMergeHelp).toBeFalsy();
       });
 
-      it('should return true before merging', () => {
-        vm.mr.isMerged = false;
+      it('should return true for a state which requires help widget', () => {
+        vm.mr.state = 'conflicts';
         expect(vm.shouldRenderMergeHelp).toBeTruthy();
       });
     });
diff --git a/spec/javascripts/vue_mr_widget/stores/mr_widget_store_spec.js b/spec/javascripts/vue_mr_widget/stores/mr_widget_store_spec.js
index 71285866302..56dd0198ae2 100644
--- a/spec/javascripts/vue_mr_widget/stores/mr_widget_store_spec.js
+++ b/spec/javascripts/vue_mr_widget/stores/mr_widget_store_spec.js
@@ -18,17 +18,5 @@ describe('MergeRequestStore', () => {
       store.setData({ ...mockData, work_in_progress: !mockData.work_in_progress });
       expect(store.hasSHAChanged).toBe(false);
     });
-
-    it('sets isMerged to true for merged state', () => {
-      store.setData({ ...mockData, state: 'merged' });
-
-      expect(store.isMerged).toBe(true);
-    });
-
-    it('sets isMerged to false for readyToMerge state', () => {
-      store.setData({ ...mockData, state: 'readyToMerge' });
-
-      expect(store.isMerged).toBe(false);
-    });
   });
 });