diff options
| author | Jose Ivan Vargas <jvargas@gitlab.com> | 2017-02-20 09:39:23 -0600 |
|---|---|---|
| committer | Jose Ivan Vargas <jvargas@gitlab.com> | 2017-02-23 15:47:23 -0600 |
| commit | 46eefbda3ae55394bae63872c8ff3d86500a1ddc (patch) | |
| tree | 6963d814927f6205836849b8226420b79d70b7a8 /spec/javascripts | |
| parent | bcab4bb5efd1cc499dc7d753115fe91b98f27bda (diff) | |
| download | gitlab-ce-46eefbda3ae55394bae63872c8ff3d86500a1ddc.tar.gz | |
Moved the dismiss-icon listener to close the callout to a button
Diffstat (limited to 'spec/javascripts')
| -rw-r--r-- | spec/javascripts/fixtures/user_callout.html.haml | 2 | ||||
| -rw-r--r-- | spec/javascripts/user_callout_spec.js | 4 |
2 files changed, 3 insertions, 3 deletions
diff --git a/spec/javascripts/fixtures/user_callout.html.haml b/spec/javascripts/fixtures/user_callout.html.haml index 430e6c829ef..ad564469a27 100644 --- a/spec/javascripts/fixtures/user_callout.html.haml +++ b/spec/javascripts/fixtures/user_callout.html.haml @@ -1,6 +1,6 @@ .user-callout .bordered-box.landing.content-block - %button.btn.btn-default.close{ type: "button" } + %button.btn.btn-default.close.close-user-callout{ type: "button" } %i.fa.fa-times.dismiss-icon .row .col-sm-3.col-xs-12.svg-container diff --git a/spec/javascripts/user_callout_spec.js b/spec/javascripts/user_callout_spec.js index 72410e5369e..ba5a2656da5 100644 --- a/spec/javascripts/user_callout_spec.js +++ b/spec/javascripts/user_callout_spec.js @@ -11,7 +11,7 @@ describe('UserCallout', function () { beforeEach(() => { loadFixtures(fixtureName); this.userCallout = new UserCallout(); - this.dismissIcon = $('.dismiss-icon'); + this.closeButton = $('.close-user-callout'); this.userCalloutContainer = $('.user-callout'); this.userCalloutBtn = $('.user-callout-btn'); Cookie.set(USER_CALLOUT_COOKIE, 0); @@ -23,7 +23,7 @@ describe('UserCallout', function () { }); it('hides when user clicks on the dismiss-icon', () => { - this.dismissIcon.click(); + this.closeButton.click(); expect(this.userCalloutContainer.is(':visible')).toBe(false); expect(Cookie.get(USER_CALLOUT_COOKIE)).toBe('1'); }); |