resolve all prefer-const eslint violations

3 files changed, 16 insertions, 17 deletions

diff --git a/spec/javascripts/activities_spec.js.es6 b/spec/javascripts/activities_spec.js.es6
index a4df983496f..7bc5b3268a0 100644
--- a/spec/javascripts/activities_spec.js.es6
+++ b/spec/javascripts/activities_spec.js.es6
@@ -1,4 +1,4 @@
-/* eslint-disable no-unused-expressions, prefer-const, no-prototype-builtins, no-new, no-shadow, max-len */
+/* eslint-disable no-unused-expressions, no-prototype-builtins, no-new, no-shadow, max-len */
 
 /*= require js.cookie.js */
 /*= require jquery.endless-scroll.js */
@@ -24,12 +24,12 @@
     }];
 
   function getEventName(index) {
-    let filter = filters[index];
+    const filter = filters[index];
     return filter.hasOwnProperty('name') ? filter.name : filter.id;
   }
 
   function getSelector(index) {
-    let filter = filters[index];
+    const filter = filters[index];
     return `#${filter.id}_event_filter`;
   }
 
@@ -48,8 +48,8 @@
 
           for (let x = 0; x < filters.length; x += 1) {
             ((x) => {
-              let shouldHighlight = i === x;
-              let testName = shouldHighlight ? 'should highlight' : 'should not highlight';
+              const shouldHighlight = i === x;
+              const testName = shouldHighlight ? 'should highlight' : 'should not highlight';
 
               it(`${testName} ${getEventName(x)}`, () => {
                 expect($(getSelector(x)).parent().hasClass('active')).toEqual(shouldHighlight);
diff --git a/spec/javascripts/gl_dropdown_spec.js.es6 b/spec/javascripts/gl_dropdown_spec.js.es6
index 377bdbea59d..06fa64b1b4e 100644
--- a/spec/javascripts/gl_dropdown_spec.js.es6
+++ b/spec/javascripts/gl_dropdown_spec.js.es6
@@ -1,4 +1,4 @@
-/* eslint-disable comma-dangle, prefer-const, no-param-reassign, no-unused-expressions, max-len */
+/* eslint-disable comma-dangle, no-param-reassign, no-unused-expressions, max-len */
 /* global Turbolinks */
 
 /*= require jquery */
@@ -22,7 +22,7 @@
 
   let remoteCallback;
 
-  let navigateWithKeys = function navigateWithKeys(direction, steps, cb, i) {
+  const navigateWithKeys = function navigateWithKeys(direction, steps, cb, i) {
     i = i || 0;
     if (!i) direction = direction.toUpperCase();
     $('body').trigger({
@@ -38,7 +38,7 @@
     }
   };
 
-  let remoteMock = function remoteMock(data, term, callback) {
+  const remoteMock = function remoteMock(data, term, callback) {
     remoteCallback = callback.bind({}, data);
   };
 
@@ -89,7 +89,7 @@
 
       it('should select a following item on DOWN keypress', () => {
         expect($(FOCUSED_ITEM_SELECTOR, this.$dropdownMenuElement).length).toBe(0);
-        let randomIndex = (Math.floor(Math.random() * (this.projectsData.length - 1)) + 0);
+        const randomIndex = (Math.floor(Math.random() * (this.projectsData.length - 1)) + 0);
         navigateWithKeys('down', randomIndex, () => {
           expect($(FOCUSED_ITEM_SELECTOR, this.$dropdownMenuElement).length).toBe(1);
           expect($(`${ITEM_SELECTOR}:eq(${randomIndex}) a`, this.$dropdownMenuElement)).toHaveClass('is-focused');
@@ -100,7 +100,7 @@
         expect($(FOCUSED_ITEM_SELECTOR, this.$dropdownMenuElement).length).toBe(0);
         navigateWithKeys('down', (this.projectsData.length - 1), () => {
           expect($(FOCUSED_ITEM_SELECTOR, this.$dropdownMenuElement).length).toBe(1);
-          let randomIndex = (Math.floor(Math.random() * (this.projectsData.length - 2)) + 0);
+          const randomIndex = (Math.floor(Math.random() * (this.projectsData.length - 2)) + 0);
           navigateWithKeys('up', randomIndex, () => {
             expect($(FOCUSED_ITEM_SELECTOR, this.$dropdownMenuElement).length).toBe(1);
             expect($(`${ITEM_SELECTOR}:eq(${((this.projectsData.length - 2) - randomIndex)}) a`, this.$dropdownMenuElement)).toHaveClass('is-focused');
@@ -110,14 +110,14 @@
 
       it('should click the selected item on ENTER keypress', () => {
         expect(this.dropdownContainerElement).toHaveClass('open');
-        let randomIndex = Math.floor(Math.random() * (this.projectsData.length - 1)) + 0;
+        const randomIndex = Math.floor(Math.random() * (this.projectsData.length - 1)) + 0;
         navigateWithKeys('down', randomIndex, () => {
           spyOn(Turbolinks, 'visit').and.stub();
           navigateWithKeys('enter', null, () => {
             expect(this.dropdownContainerElement).not.toHaveClass('open');
-            let link = $(`${ITEM_SELECTOR}:eq(${randomIndex}) a`, this.$dropdownMenuElement);
+            const link = $(`${ITEM_SELECTOR}:eq(${randomIndex}) a`, this.$dropdownMenuElement);
             expect(link).toHaveClass('is-active');
-            let linkedLocation = link.attr('href');
+            const linkedLocation = link.attr('href');
             if (linkedLocation && linkedLocation !== '#') expect(Turbolinks.visit).toHaveBeenCalledWith(linkedLocation);
           });
         });
@@ -171,9 +171,8 @@
       });
     });
 
-
     it('should still have input value on close and restore', () => {
-      let $searchInput = $(SEARCH_INPUT_SELECTOR);
+      const $searchInput = $(SEARCH_INPUT_SELECTOR);
       initDropDown.call(this, false, true);
       $searchInput
         .trigger('focus')
diff --git a/spec/javascripts/labels_issue_sidebar_spec.js.es6 b/spec/javascripts/labels_issue_sidebar_spec.js.es6
index 1f254c8561c..0d19b4a25b9 100644
--- a/spec/javascripts/labels_issue_sidebar_spec.js.es6
+++ b/spec/javascripts/labels_issue_sidebar_spec.js.es6
@@ -1,4 +1,4 @@
-/* eslint-disable no-new, prefer-const */
+/* eslint-disable no-new */
 /* global IssuableContext */
 /* global LabelsSelect */
 
@@ -33,7 +33,7 @@
             LABELS_DATA.push({ id: i, title: `test ${i}`, color: '#5CB85C' });
           }
         } else if (req.url === '/root/test/issues/2.json') {
-          let tmp = [];
+          const tmp = [];
           for (let i = 0; i < saveLabelCount; i += 1) {
             tmp.push({ id: i, title: `test ${i}`, color: '#5CB85C' });
           }