summaryrefslogtreecommitdiff
path: root/spec/lib/banzai
diff options
context:
space:
mode:
authorDouwe Maan <douwe@selenight.nl>2017-02-16 14:06:22 -0600
committerDouwe Maan <douwe@selenight.nl>2017-02-16 14:06:24 -0600
commit02aad721f16a8eb4d5fd7499693614dadfa64770 (patch)
treef112cbb38ffbb125a29080467568436bf1cba1d8 /spec/lib/banzai
parenta2801ec429a0ac02e622d61119439ff71150acf2 (diff)
downloadgitlab-ce-02aad721f16a8eb4d5fd7499693614dadfa64770.tar.gz
Only yield valid references in ReferenceFilter.references_inonly-yield-valid-reference-matches
Diffstat (limited to 'spec/lib/banzai')
-rw-r--r--spec/lib/banzai/filter/issue_reference_filter_spec.rb24
1 files changed, 23 insertions, 1 deletions
diff --git a/spec/lib/banzai/filter/issue_reference_filter_spec.rb b/spec/lib/banzai/filter/issue_reference_filter_spec.rb
index 456dbac0698..11607d4fb26 100644
--- a/spec/lib/banzai/filter/issue_reference_filter_spec.rb
+++ b/spec/lib/banzai/filter/issue_reference_filter_spec.rb
@@ -311,7 +311,7 @@ describe Banzai::Filter::IssueReferenceFilter, lib: true do
end
end
- describe '#issues_per_Project' do
+ describe '#issues_per_project' do
context 'using an internal issue tracker' do
it 'returns a Hash containing the issues per project' do
doc = Nokogiri::HTML.fragment('')
@@ -346,4 +346,26 @@ describe Banzai::Filter::IssueReferenceFilter, lib: true do
end
end
end
+
+ describe '.references_in' do
+ let(:merge_request) { create(:merge_request) }
+
+ it 'yields valid references' do
+ expect do |b|
+ described_class.references_in(issue.to_reference, &b)
+ end.to yield_with_args(issue.to_reference, issue.iid, nil, nil, MatchData)
+ end
+
+ it "doesn't yield invalid references" do
+ expect do |b|
+ described_class.references_in('#0', &b)
+ end.not_to yield_control
+ end
+
+ it "doesn't yield unsupported references" do
+ expect do |b|
+ described_class.references_in(merge_request.to_reference, &b)
+ end.not_to yield_control
+ end
+ end
end