diff options
author | GitLab Bot <gitlab-bot@gitlab.com> | 2020-03-11 12:09:26 +0000 |
---|---|---|
committer | GitLab Bot <gitlab-bot@gitlab.com> | 2020-03-11 12:09:26 +0000 |
commit | c9687bdf58e9d4a9c3942f587bd4841f42e3b5de (patch) | |
tree | a60a2e20f152483be6a92bacdf10564bbc96c664 /spec/lib/banzai | |
parent | 3f3e4bcc50a3280d03299c2c263eafd9c8e3bd7b (diff) | |
download | gitlab-ce-c9687bdf58e9d4a9c3942f587bd4841f42e3b5de.tar.gz |
Add latest changes from gitlab-org/gitlab@master
Diffstat (limited to 'spec/lib/banzai')
-rw-r--r-- | spec/lib/banzai/filter/inline_grafana_metrics_filter_spec.rb | 14 |
1 files changed, 10 insertions, 4 deletions
diff --git a/spec/lib/banzai/filter/inline_grafana_metrics_filter_spec.rb b/spec/lib/banzai/filter/inline_grafana_metrics_filter_spec.rb index 2092b9e9db8..28bf5bd3e92 100644 --- a/spec/lib/banzai/filter/inline_grafana_metrics_filter_spec.rb +++ b/spec/lib/banzai/filter/inline_grafana_metrics_filter_spec.rb @@ -46,11 +46,9 @@ describe Banzai::Filter::InlineGrafanaMetricsFilter do end context 'when "panelId" parameter is missing' do - let(:dashboard_path) { '/d/XDaNK6amz/gitlab-omnibus-redis' } + let(:dashboard_path) { '/d/XDaNK6amz/gitlab-omnibus-redis?from=1570397739557&to=1570484139557' } - it 'leaves the markdown unchanged' do - expect(unescape(doc.to_s)).to eq(input) - end + it_behaves_like 'a metrics embed filter' end context 'when time window parameters are missing' do @@ -86,6 +84,14 @@ describe Banzai::Filter::InlineGrafanaMetricsFilter do end end + context 'when no parameters are provided' do + let(:dashboard_path) { '/d/XDaNK6amz/gitlab-omnibus-redis' } + + it 'inserts a placeholder' do + expect(embed_url).to be_present + end + end + private # Nokogiri escapes the URLs, but we don't care about that |