Move Gitaly feature flag logic to Feature::Gitaly

The GitalyClient held a lot of logic which was all very tightly coupled.
In this instance the feature logic was extracted to make it do just a
little less and create a bit more focus in the GitalyClient's
responsibilies.

1 files changed, 32 insertions, 0 deletions

diff --git a/spec/lib/feature/gitaly_spec.rb b/spec/lib/feature/gitaly_spec.rb
new file mode 100644
index 00000000000..12923e4ec41
--- /dev/null
+++ b/spec/lib/feature/gitaly_spec.rb
@@ -0,0 +1,32 @@
+require 'spec_helper'
+
+describe Feature::Gitaly do
+  let(:feature_flag) { "mepmep" }
+
+  describe ".enabled?" do
+    context 'when the gate is closed' do
+      before do
+        allow(Feature).to receive(:enabled?).with("gitaly_mepmep").and_return(false)
+      end
+
+      it 'returns false' do
+        expect(described_class.enabled?(feature_flag)).to be(false)
+      end
+    end
+  end
+
+  describe ".server_feature_flags" do
+    before do
+      stub_const("#{described_class}::SERVER_FEATURE_FLAGS", [feature_flag])
+      allow(Feature).to receive(:enabled?).with("gitaly_mepmep").and_return(false)
+    end
+
+    subject { described_class.server_feature_flags }
+
+    it { is_expected.to be_a(Hash) }
+
+    context 'when one flag is disabled' do
+      it { is_expected.to eq("gitaly-feature-mepmep" => "false") }
+    end
+  end
+end