summaryrefslogtreecommitdiff
path: root/spec/lib/gitlab/background_migration/populate_external_pipeline_source_spec.rb
diff options
context:
space:
mode:
authorYorick Peterse <yorickpeterse@gmail.com>2019-04-29 14:16:03 +0200
committerYorick Peterse <yorickpeterse@gmail.com>2019-06-17 17:09:05 +0200
commit8469f59d786be6762908f62d642625790999cb9b (patch)
tree03f99c605e465673e017e775a623ffa5b62f18d3 /spec/lib/gitlab/background_migration/populate_external_pipeline_source_spec.rb
parent0f777a8d49568d3f5ffdd4b75b594f07e9fbd2f0 (diff)
downloadgitlab-ce-8469f59d786be6762908f62d642625790999cb9b.tar.gz
Backport the EE schema and migrations to CE
This backports all EE schema changes to CE, including EE migrations, ensuring both use the same schema. == Updated tests A spec related to ghost and support bot users had to be modified to make it pass. The spec in question assumes that the "support_bot" column exists when defining the spec. In the single codebase setup this is not the case, as the column is backported in a later migration. Any attempt to use a different schema version or use of "around" blocks to conditionally disable specs won't help, as reverting the backport migration would also drop the "support_bot" column. Removing the "support_bot" tests entirely appears to be the only solution. We also need to update some foreign key tests now that we have backported the EE columns. Fortunately, these changes are very minor. == Backporting migrations This commit moves EE specific migrations (except those for the Geo tracking database) and related files to CE, and also removes any traces of the ee/db directory. Some migrations had to be modified or removed, as they no longer work with the schema being backported. These migrations were all quite old, so we opted for removing them where modifying them would take too much time and effort. Some old migrations were modified in EE, while also existing in CE. In these cases we took the EE code, and in one case removed them entirely. It's not worth spending time trying to merge these changes somehow as we plan to remove old migrations around the release of 12.0, see https://gitlab.com/gitlab-org/gitlab-ce/issues/59177 for more details.
Diffstat (limited to 'spec/lib/gitlab/background_migration/populate_external_pipeline_source_spec.rb')
-rw-r--r--spec/lib/gitlab/background_migration/populate_external_pipeline_source_spec.rb72
1 files changed, 0 insertions, 72 deletions
diff --git a/spec/lib/gitlab/background_migration/populate_external_pipeline_source_spec.rb b/spec/lib/gitlab/background_migration/populate_external_pipeline_source_spec.rb
deleted file mode 100644
index c6bc3db88a3..00000000000
--- a/spec/lib/gitlab/background_migration/populate_external_pipeline_source_spec.rb
+++ /dev/null
@@ -1,72 +0,0 @@
-# frozen_string_literal: true
-
-require 'spec_helper'
-
-# rubocop:disable RSpec/FactoriesInMigrationSpecs
-describe Gitlab::BackgroundMigration::PopulateExternalPipelineSource, :migration, schema: 20180916011959 do
- let(:migration) { described_class.new }
-
- before do
- # This migration was created before we introduced metadata configs
- stub_feature_flags(ci_build_metadata_config: false)
- # This migration was created before we introduced ProjectCiCdSetting#default_git_depth
- allow_any_instance_of(ProjectCiCdSetting).to receive(:default_git_depth).and_return(nil)
- allow_any_instance_of(ProjectCiCdSetting).to receive(:default_git_depth=).and_return(0)
- end
-
- let!(:internal_pipeline) { create(:ci_pipeline, source: :web) }
- let(:pipelines) { [internal_pipeline, unknown_pipeline].map(&:id) }
-
- let!(:unknown_pipeline) do
- build(:ci_pipeline, source: :unknown)
- .tap { |pipeline| pipeline.save(validate: false) }
- end
-
- subject { migration.perform(pipelines.min, pipelines.max) }
-
- shared_examples 'no changes' do
- it 'does not change the pipeline source' do
- expect { subject }.not_to change { unknown_pipeline.reload.source }
- end
- end
-
- context 'when unknown pipeline is external' do
- before do
- create(:generic_commit_status, pipeline: unknown_pipeline)
- end
-
- it 'populates the pipeline source' do
- subject
-
- expect(unknown_pipeline.reload.source).to eq('external')
- end
-
- it 'can be repeated without effect' do
- subject
-
- expect { subject }.not_to change { unknown_pipeline.reload.source }
- end
- end
-
- context 'when unknown pipeline has just a build' do
- before do
- create(:ci_build, pipeline: unknown_pipeline)
- end
-
- it_behaves_like 'no changes'
- end
-
- context 'when unknown pipeline has no statuses' do
- it_behaves_like 'no changes'
- end
-
- context 'when unknown pipeline has a build and a status' do
- before do
- create(:generic_commit_status, pipeline: unknown_pipeline)
- create(:ci_build, pipeline: unknown_pipeline)
- end
-
- it_behaves_like 'no changes'
- end
-end
-# rubocop:enable RSpec/FactoriesInMigrationSpecs