summaryrefslogtreecommitdiff
path: root/spec/lib/gitlab/ci/config/entry/coverage_spec.rb
diff options
context:
space:
mode:
authorLeandro Camargo <leandroico@gmail.com>2016-11-26 01:02:08 -0200
committerLeandro Camargo <leandroico@gmail.com>2017-01-25 01:07:44 -0200
commitf1e920ed86133bfea0abfc66ca44282813822073 (patch)
treefe6f35c9af1aa1d3d96e6f405692717299b80cc0 /spec/lib/gitlab/ci/config/entry/coverage_spec.rb
parentbb12ee051f95ee747c0e2b98a85675de53dca8ea (diff)
downloadgitlab-ce-f1e920ed86133bfea0abfc66ca44282813822073.tar.gz
Simplify coverage setting and comply to some requests in code review
Diffstat (limited to 'spec/lib/gitlab/ci/config/entry/coverage_spec.rb')
-rw-r--r--spec/lib/gitlab/ci/config/entry/coverage_spec.rb14
1 files changed, 7 insertions, 7 deletions
diff --git a/spec/lib/gitlab/ci/config/entry/coverage_spec.rb b/spec/lib/gitlab/ci/config/entry/coverage_spec.rb
index 9e59755d9f8..0549dbc732b 100644
--- a/spec/lib/gitlab/ci/config/entry/coverage_spec.rb
+++ b/spec/lib/gitlab/ci/config/entry/coverage_spec.rb
@@ -5,35 +5,35 @@ describe Gitlab::Ci::Config::Entry::Coverage do
describe 'validations' do
context 'when entry config value is correct' do
- let(:config) { { output_filter: 'Code coverage: \d+\.\d+' } }
+ let(:config) { 'Code coverage: \d+\.\d+' }
describe '#value' do
subject { entry.value }
- it { is_expected.to eq config }
+ it { is_expected.to eq config }
end
describe '#errors' do
subject { entry.errors }
- it { is_expected.to be_empty }
+ it { is_expected.to be_empty }
end
describe '#valid?' do
subject { entry }
- it { is_expected.to be_valid }
+ it { is_expected.to be_valid }
end
end
context 'when entry value is not correct' do
- let(:config) { { output_filter: '(malformed regexp' } }
+ let(:config) { '(malformed regexp' }
describe '#errors' do
subject { entry.errors }
- it { is_expected.to include /coverage output filter must be a regular expression/ }
+ it { is_expected.to include /coverage config must be a regular expression/ }
end
describe '#valid?' do
subject { entry }
- it { is_expected.not_to be_valid }
+ it { is_expected.not_to be_valid }
end
end
end