diff options
author | Marius Bobin <mbobin@gitlab.com> | 2019-08-21 18:48:16 +0000 |
---|---|---|
committer | Stan Hu <stanhu@gmail.com> | 2019-08-21 18:48:16 +0000 |
commit | 65b20f35dc2b9a52d3bac5e234f124b7b3e466a3 (patch) | |
tree | 7e7c0dd1f18dcf46782f428944d5fc9cb0cbe2ac /spec/lib/gitlab/ci/pipeline/expression/lexeme/matches_spec.rb | |
parent | 9a0c1f64f540c1f07b2742a4c1c3ef4bee749bfd (diff) | |
download | gitlab-ce-65b20f35dc2b9a52d3bac5e234f124b7b3e466a3.tar.gz |
Ensure CI matching operator receives an object
Ensure the evaluation of right-hand side expression always
results in the returning of an object or an empty String
Diffstat (limited to 'spec/lib/gitlab/ci/pipeline/expression/lexeme/matches_spec.rb')
-rw-r--r-- | spec/lib/gitlab/ci/pipeline/expression/lexeme/matches_spec.rb | 28 |
1 files changed, 28 insertions, 0 deletions
diff --git a/spec/lib/gitlab/ci/pipeline/expression/lexeme/matches_spec.rb b/spec/lib/gitlab/ci/pipeline/expression/lexeme/matches_spec.rb index 4e4f1bf6ad3..a527783ffac 100644 --- a/spec/lib/gitlab/ci/pipeline/expression/lexeme/matches_spec.rb +++ b/spec/lib/gitlab/ci/pipeline/expression/lexeme/matches_spec.rb @@ -69,6 +69,34 @@ describe Gitlab::Ci::Pipeline::Expression::Lexeme::Matches do it { is_expected.to eq(false) } end + context 'when right is nil' do + let(:left_value) { 'my-awesome-string' } + let(:right_value) { nil } + + it { is_expected.to eq(false) } + end + + context 'when left and right are nil' do + let(:left_value) { nil } + let(:right_value) { nil } + + it { is_expected.to eq(false) } + end + + context 'when left is an empty string' do + let(:left_value) { '' } + let(:right_value) { Gitlab::UntrustedRegexp.new('pattern') } + + it { is_expected.to eq(false) } + end + + context 'when left and right are empty strings' do + let(:left_value) { '' } + let(:right_value) { Gitlab::UntrustedRegexp.new('') } + + it { is_expected.to eq(true) } + end + context 'when left is a multiline string and matches right' do let(:left_value) do <<~TEXT |