Add `ci_dag_limit_needs` feature flaglimit-amount-of-needs

This makes to limit `needs:` to 5 by default.
Allow to increase the limit to 50 with disable of FF.

1 files changed, 33 insertions, 3 deletions

diff --git a/spec/lib/gitlab/ci/pipeline/seed/build_spec.rb b/spec/lib/gitlab/ci/pipeline/seed/build_spec.rb
index e0fbd2e7369..5d4dec5899a 100644
--- a/spec/lib/gitlab/ci/pipeline/seed/build_spec.rb
+++ b/spec/lib/gitlab/ci/pipeline/seed/build_spec.rb
@@ -386,12 +386,16 @@ describe Gitlab::Ci::Pipeline::Seed::Build do
   describe 'applying needs: dependency' do
     subject { seed_build }
 
+    let(:needs_count) { 1 }
+
+    let(:needs_attributes) do
+      Array.new(needs_count, name: 'build')
+    end
+
     let(:attributes) do
       {
         name: 'rspec',
-        needs_attributes: [{
-          name: 'build'
-        }]
+        needs_attributes: needs_attributes
       }
     end
 
@@ -429,5 +433,31 @@ describe Gitlab::Ci::Pipeline::Seed::Build do
         expect(subject.errors).to be_empty
       end
     end
+
+    context 'when lower limit of needs is reached' do
+      before do
+        stub_feature_flags(ci_dag_limit_needs: true)
+      end
+
+      let(:needs_count) { described_class::LOW_NEEDS_LIMIT + 1 }
+
+      it "returns an error" do
+        expect(subject.errors).to contain_exactly(
+          "rspec: one job can only need 5 others, but you have listed 6. See needs keyword documentation for more details")
+      end
+    end
+
+    context 'when upper limit of needs is reached' do
+      before do
+        stub_feature_flags(ci_dag_limit_needs: false)
+      end
+
+      let(:needs_count) { described_class::HARD_NEEDS_LIMIT + 1 }
+
+      it "returns an error" do
+        expect(subject.errors).to contain_exactly(
+          "rspec: one job can only need 50 others, but you have listed 51. See needs keyword documentation for more details")
+      end
+    end
   end
 end