Add code review remarks

Change small things for better readability

1 files changed, 22 insertions, 24 deletions

diff --git a/spec/lib/gitlab/cycle_analytics/group_stage_summary_spec.rb b/spec/lib/gitlab/cycle_analytics/group_stage_summary_spec.rb
index 6505fc714c4..eea4f33ccb8 100644
--- a/spec/lib/gitlab/cycle_analytics/group_stage_summary_spec.rb
+++ b/spec/lib/gitlab/cycle_analytics/group_stage_summary_spec.rb
@@ -22,6 +22,16 @@ describe Gitlab::CycleAnalytics::GroupStageSummary do
       it "finds the number of issues created after it" do
         expect(subject.first[:value]).to eq(2)
       end
+
+      context 'with subgroups' do
+        before do
+          Timecop.freeze(5.days.from_now) { create(:issue, project: create(:project, namespace: create(:group, parent: group))) }
+        end
+
+        it "finds issues from them" do
+          expect(subject.first[:value]).to eq(3)
+        end
+      end
     end
 
     context 'with other projects' do
@@ -35,18 +45,6 @@ describe Gitlab::CycleAnalytics::GroupStageSummary do
         expect(subject.first[:value]).to eq(2)
       end
     end
-
-    context 'with subgroups' do
-      before do
-        Timecop.freeze(5.days.from_now) { create(:issue, project: create(:project, namespace: create(:group, parent: group))) }
-        Timecop.freeze(5.days.from_now) { create(:issue, project: project) }
-        Timecop.freeze(5.days.from_now) { create(:issue, project: project_2) }
-      end
-
-      it "finds issues from them" do
-        expect(subject.first[:value]).to eq(3)
-      end
-    end
   end
 
   describe "#deploys" do
@@ -61,29 +59,29 @@ describe Gitlab::CycleAnalytics::GroupStageSummary do
       it "finds the number of deploys made created after it" do
         expect(subject.second[:value]).to eq(2)
       end
-    end
 
-    context 'with other projects' do
-      before do
-        Timecop.freeze(5.days.from_now) do
-          create(:deployment, :success, project: create(:project, :repository, namespace: create(:group)))
+      context 'with subgroups' do
+        before do
+          Timecop.freeze(5.days.from_now) do
+            create(:deployment, :success, project: create(:project, :repository, namespace: create(:group, parent: group)))
+          end
         end
-      end
 
-      it "doesn't find deploys from them" do
-        expect(subject.second[:value]).to eq(0)
+        it "finds deploys from them" do
+          expect(subject.second[:value]).to eq(3)
+        end
       end
     end
 
-    context 'with subgroups' do
+    context 'with other projects' do
       before do
         Timecop.freeze(5.days.from_now) do
-          create(:deployment, :success, project: create(:project, :repository, namespace: create(:group, parent: group)))
+          create(:deployment, :success, project: create(:project, :repository, namespace: create(:group)))
         end
       end
 
-      it "finds deploys from them" do
-        expect(subject.second[:value]).to eq(1)
+      it "doesn't find deploys from them" do
+        expect(subject.second[:value]).to eq(0)
       end
     end
   end