diff options
author | Nick Thomas <nick@gitlab.com> | 2019-02-14 16:45:53 +0000 |
---|---|---|
committer | Nick Thomas <nick@gitlab.com> | 2019-02-14 23:52:30 +0000 |
commit | 9afc4f9d11c83a2371c7f7356ec66b01f5b519b6 (patch) | |
tree | b93c16fce722ab209e4840ca69e47b18de6638b2 /spec/lib/gitlab/danger | |
parent | bbd0a2ce91f2d43350382c7ce83729f33c39c125 (diff) | |
download | gitlab-ce-9afc4f9d11c83a2371c7f7356ec66b01f5b519b6.tar.gz |
Reviewer roulette ignores changelogs
Diffstat (limited to 'spec/lib/gitlab/danger')
-rw-r--r-- | spec/lib/gitlab/danger/helper_spec.rb | 7 |
1 files changed, 6 insertions, 1 deletions
diff --git a/spec/lib/gitlab/danger/helper_spec.rb b/spec/lib/gitlab/danger/helper_spec.rb index ac3e4b04230..793cac593a2 100644 --- a/spec/lib/gitlab/danger/helper_spec.rb +++ b/spec/lib/gitlab/danger/helper_spec.rb @@ -184,7 +184,7 @@ describe Gitlab::Danger::Helper do describe '#changes_by_category' do it 'categorizes changed files' do - expect(fake_git).to receive(:added_files) { %w[foo foo.md foo.rb foo.js db/foo qa/foo] } + expect(fake_git).to receive(:added_files) { %w[foo foo.md foo.rb foo.js db/foo qa/foo ee/changelogs/foo.yml] } allow(fake_git).to receive(:modified_files) { [] } allow(fake_git).to receive(:renamed_files) { [] } @@ -193,6 +193,7 @@ describe Gitlab::Danger::Helper do database: %w[db/foo], docs: %w[foo.md], frontend: %w[foo.js], + none: %w[ee/changelogs/foo.yml], qa: %w[qa/foo], unknown: %w[foo] ) @@ -260,6 +261,9 @@ describe Gitlab::Danger::Helper do 'ee/db/foo' | :database 'ee/qa/foo' | :qa + 'changelogs/foo' | :none + 'ee/changelogs/foo' | :none + 'FOO' | :unknown 'foo' | :unknown @@ -283,6 +287,7 @@ describe Gitlab::Danger::Helper do :docs | '~Documentation' :foo | '~foo' :frontend | '~frontend' + :none | '' :qa | '~QA' end |