diff options
| author | Yorick Peterse <yorickpeterse@gmail.com> | 2016-06-15 17:04:07 +0200 |
|---|---|---|
| committer | Yorick Peterse <yorickpeterse@gmail.com> | 2016-06-15 17:04:07 +0200 |
| commit | 816c453558c6d25fd8724bd3fe08e6fd221f2887 (patch) | |
| tree | f4ff1664f6bf0e8cc64c92f05f973b8b1927b580 /spec/lib/gitlab/database | |
| parent | 8966263e0c738e85d8872aee0bfcf7fbe77b22a6 (diff) | |
| download | gitlab-ce-816c453558c6d25fd8724bd3fe08e6fd221f2887.tar.gz | |
Don't update columns in batches in a transaction
This ensures that whatever locks are acquired aren't held onto until the
end of the transaction (= after _all_ rows have been updated). Timing
wise there's also no difference between using a transaction and not
using one.
Diffstat (limited to 'spec/lib/gitlab/database')
| -rw-r--r-- | spec/lib/gitlab/database/migration_helpers_spec.rb | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/spec/lib/gitlab/database/migration_helpers_spec.rb b/spec/lib/gitlab/database/migration_helpers_spec.rb index b46f56196eb..9096ad101b0 100644 --- a/spec/lib/gitlab/database/migration_helpers_spec.rb +++ b/spec/lib/gitlab/database/migration_helpers_spec.rb @@ -90,7 +90,7 @@ describe Gitlab::Database::MigrationHelpers, lib: true do before do expect(model).to receive(:transaction_open?).and_return(false) - expect(model).to receive(:transaction).twice.and_yield + expect(model).to receive(:transaction).and_yield expect(model).to receive(:add_column). with(:projects, :foo, :integer, default: nil) |