Improve API specs

2 files changed, 103 insertions, 30 deletions

diff --git a/spec/lib/mattermost/command_spec.rb b/spec/lib/mattermost/command_spec.rb
index f70aee7f3e5..5ccf1100898 100644
--- a/spec/lib/mattermost/command_spec.rb
+++ b/spec/lib/mattermost/command_spec.rb
@@ -2,21 +2,60 @@ require 'spec_helper'
 
 describe Mattermost::Command do
   let(:params) { { 'token' => 'token', team_id: 'abc' } }
-  let(:user) { build(:user) }
 
   before do
-    Mattermost::Session.base_uri("http://mattermost.example.com")
-  end
+    Mattermost::Session.base_uri('http://mattermost.example.com')
 
-  subject { described_class.new(user) }
+    allow_any_instance_of(Mattermost::Client).to receive(:with_session).
+      and_yield(Mattermost::Session.new(nil))
+  end
 
   describe '#create' do
-    it 'interpolates the team id' do
-      allow(subject).to receive(:json_post).
-        with('/api/v3/teams/abc/commands/create', body: params.to_json).
-        and_return('token' => 'token')
+    let(:params) do
+      { team_id: 'abc',
+        trigger: 'gitlab'
+      }
+    end
+
+    subject { described_class.new(nil).create(params) }
+
+    context 'for valid trigger word' do
+      before do
+        stub_request(:post, 'http://mattermost.example.com/api/v3/teams/abc/commands/create').
+          with(body: {
+            team_id: 'abc',
+            trigger: 'gitlab' }.to_json).
+          to_return(
+            status: 200,
+            headers: { 'Content-Type' => 'application/json' },
+            body: { token: 'token' }.to_json
+          )
+      end
+
+      it 'returns a token' do
+        is_expected.to eq('token')
+      end
+    end
+
+    context 'for error message' do
+      before do
+        stub_request(:post, 'http://mattermost.example.com/api/v3/teams/abc/commands/create').
+          to_return(
+            status: 500,
+            headers: { 'Content-Type' => 'application/json' },
+            body: {
+              id: 'api.command.duplicate_trigger.app_error',
+              message: 'This trigger word is already in use. Please choose another word.',
+              detailed_error: '',
+              request_id: 'obc374man7bx5r3dbc1q5qhf3r',
+              status_code: 500
+            }.to_json
+          )
+      end
 
-      subject.create(params)
+      it 'raises an error with message' do
+        expect { subject }.to raise_error(Mattermost::Error, 'This trigger word is already in use. Please choose another word.')
+      end
     end
   end
 end
diff --git a/spec/lib/mattermost/team_spec.rb b/spec/lib/mattermost/team_spec.rb
index 704579f0f48..2d14be6bcc2 100644
--- a/spec/lib/mattermost/team_spec.rb
+++ b/spec/lib/mattermost/team_spec.rb
@@ -1,32 +1,66 @@
 require 'spec_helper'
 
 describe Mattermost::Team do
+  before do
+    Mattermost::Session.base_uri('http://mattermost.example.com')
+
+    allow_any_instance_of(Mattermost::Client).to receive(:with_session).
+      and_yield(Mattermost::Session.new(nil))
+  end
+
   describe '#all' do
-    let(:user) { build(:user) }
-    let(:response) do
-      [{
-        "id" => "xiyro8huptfhdndadpz8r3wnbo",
-        "create_at" => 1482174222155,
-        "update_at" => 1482174222155,
-        "delete_at" => 0,
-        "display_name" => "chatops",
-        "name" => "chatops",
-        "email" => "admin@example.com",
-        "type" => "O",
-        "company_name" => "",
-        "allowed_domains" => "",
-        "invite_id" => "o4utakb9jtb7imctdfzbf9r5ro",
-        "allow_open_invite" => false }]
-    end
+    subject { described_class.new(nil).all }
+
+    context 'for valid request' do
+      let(:response) do
+        [{
+           "id" => "xiyro8huptfhdndadpz8r3wnbo",
+           "create_at" => 1482174222155,
+           "update_at" => 1482174222155,
+           "delete_at" => 0,
+           "display_name" => "chatops",
+           "name" => "chatops",
+           "email" => "admin@example.com",
+           "type" => "O",
+           "company_name" => "",
+           "allowed_domains" => "",
+           "invite_id" => "o4utakb9jtb7imctdfzbf9r5ro",
+           "allow_open_invite" => false }]
+      end
 
-    subject { described_class.new(user) }
+      before do
+        stub_request(:get, 'http://mattermost.example.com/api/v3/teams/all').
+          to_return(
+            status: 200,
+            headers: { 'Content-Type' => 'application/json' },
+            body: response.to_json
+          )
+      end
 
-    before do
-      allow(subject).to receive(:json_get).and_return(response)
+      it 'returns a token' do
+        is_expected.to eq(response)
+      end
     end
 
-    it 'gets the teams' do
-      expect(subject.all.count).to be(1)
+    context 'for error message' do
+      before do
+        stub_request(:get, 'http://mattermost.example.com/api/v3/teams/all').
+          to_return(
+            status: 500,
+            headers: { 'Content-Type' => 'application/json' },
+            body: {
+              id: 'api.team.list.app_error',
+              message: 'Cannot list teams.',
+              detailed_error: '',
+              request_id: 'obc374man7bx5r3dbc1q5qhf3r',
+              status_code: 500
+            }.to_json
+          )
+      end
+
+      it 'raises an error with message' do
+        expect { subject }.to raise_error(Mattermost::Error, 'Cannot list teams.')
+      end
     end
   end
 end