diff options
| author | Toon Claes <toon@iotcl.com> | 2017-09-19 09:44:58 +0200 |
|---|---|---|
| committer | Toon Claes <toon@iotcl.com> | 2017-10-06 22:37:40 +0200 |
| commit | d13669716ab0c31ce9039ae9f7f073e33a4dc40f (patch) | |
| tree | 001bb2e6aa76ea7531c93e469c396f7fdcc408a7 /spec/lib/system_check | |
| parent | 2cf5dca8f80cdefeb8932bf80417f52f289668c8 (diff) | |
| download | gitlab-ce-d13669716ab0c31ce9039ae9f7f073e33a4dc40f.tar.gz | |
Create idea of read-only databasetc-geo-read-only-idea
In GitLab EE, a GitLab instance can be read-only (e.g. when it's a Geo
secondary node). But in GitLab CE it also might be useful to have the
"read-only" idea around. So port it back to GitLab CE.
Also having the principle of read-only in GitLab CE would hopefully
lead to less errors introduced, doing write operations when there
aren't allowed for read-only calls.
Closes gitlab-org/gitlab-ce#37534.
Diffstat (limited to 'spec/lib/system_check')
| -rw-r--r-- | spec/lib/system_check/app/git_user_default_ssh_config_check_spec.rb | 8 |
1 files changed, 8 insertions, 0 deletions
diff --git a/spec/lib/system_check/app/git_user_default_ssh_config_check_spec.rb b/spec/lib/system_check/app/git_user_default_ssh_config_check_spec.rb index a0fb86345f3..b4b83b70d1c 100644 --- a/spec/lib/system_check/app/git_user_default_ssh_config_check_spec.rb +++ b/spec/lib/system_check/app/git_user_default_ssh_config_check_spec.rb @@ -39,6 +39,14 @@ describe SystemCheck::App::GitUserDefaultSSHConfigCheck do it { is_expected.to eq(expected_result) } end + + it 'skips GitLab read-only instances' do + stub_user + stub_home_dir + allow(Gitlab::Database).to receive(:read_only?).and_return(true) + + is_expected.to be_truthy + end end describe '#check?' do |