diff options
author | Rémy Coutable <remy@rymai.me> | 2019-09-05 16:50:05 +0000 |
---|---|---|
committer | Rémy Coutable <remy@rymai.me> | 2019-09-05 16:50:05 +0000 |
commit | 181a9698f4d0fd66f7379bf9927a485f4cb429b9 (patch) | |
tree | 14d29826ae2c447dc808f1f42128b4994058b5b2 /spec/lib | |
parent | 0e335ec90e7a03e8a6fd3df939de0c647f8a4360 (diff) | |
parent | 79ec54c39e8ecc397961a8b76dea239e52c7753c (diff) | |
download | gitlab-ce-181a9698f4d0fd66f7379bf9927a485f4cb429b9.tar.gz |
Merge branch 'danger-review-pipeline' into 'master'
Add Danger Roulette rules for pipeline files
See merge request gitlab-org/gitlab-ce!32616
Diffstat (limited to 'spec/lib')
-rw-r--r-- | spec/lib/gitlab/danger/helper_spec.rb | 6 | ||||
-rw-r--r-- | spec/lib/gitlab/danger/teammate_spec.rb | 12 |
2 files changed, 17 insertions, 1 deletions
diff --git a/spec/lib/gitlab/danger/helper_spec.rb b/spec/lib/gitlab/danger/helper_spec.rb index 2990594c538..710564b7540 100644 --- a/spec/lib/gitlab/danger/helper_spec.rb +++ b/spec/lib/gitlab/danger/helper_spec.rb @@ -168,9 +168,13 @@ describe Gitlab::Danger::Helper do 'Gemfile.lock' | :backend 'Procfile' | :backend 'Rakefile' | :backend - '.gitlab-ci.yml' | :backend 'FOO_VERSION' | :backend + '.gitlab-ci.yml' | :engineering_productivity + '.gitlab/ci/cng.gitlab-ci.yml' | :engineering_productivity + '.gitlab/ci/ee-specific-checks.gitlab-ci.yml' | :engineering_productivity + 'lib/gitlab/ci/templates/Security/SAST.gitlab-ci.yml' | :backend + 'ee/FOO_VERSION' | :unknown 'db/schema.rb' | :database diff --git a/spec/lib/gitlab/danger/teammate_spec.rb b/spec/lib/gitlab/danger/teammate_spec.rb index afbc3896a70..ca036390bde 100644 --- a/spec/lib/gitlab/danger/teammate_spec.rb +++ b/spec/lib/gitlab/danger/teammate_spec.rb @@ -65,6 +65,18 @@ describe Gitlab::Danger::Teammate do expect(subject.reviewer?(project, :test, labels)).to be_falsey end end + + context 'when role is Backend Engineer, Engineering Productivity' do + let(:role) { 'Backend Engineer, Engineering Productivity' } + + it '#reviewer? returns true' do + expect(subject.reviewer?(project, :engineering_productivity, labels)).to be_truthy + end + + it '#maintainer? returns false' do + expect(subject.maintainer?(project, :engineering_productivity, labels)).to be_falsey + end + end end end |