summaryrefslogtreecommitdiff
path: root/spec/lib
diff options
context:
space:
mode:
authorStan Hu <stanhu@gmail.com>2018-04-01 21:06:56 -0700
committerStan Hu <stanhu@gmail.com>2018-04-02 08:58:17 -0700
commit05e1cbc4cae3032eca371e09f35a451628a4e9c6 (patch)
treeabe96ae2be630685eaca7ace2e17c97c396cdee2 /spec/lib
parent6b89ab116110f177ecb809adf429fe05f76e97f5 (diff)
downloadgitlab-ce-05e1cbc4cae3032eca371e09f35a451628a4e9c6.tar.gz
Move Sidekiq exporter logs to log/sidekiq_exporter.logsh-move-sidekiq-exporter-logs
The Sidekiq exporter logs were mixing with the normal Sidekiq logs. In order to support structured logging in Sidekiq, we either need to split this data out or convert the exporter to produce structured logs. Since Sidekiq job processing is fundamentally different information from Web server traffic, it seems cleaner to move the metrics traffic into a separate file, where they can be parsed by a different filter if needed. Relates to #20060
Diffstat (limited to 'spec/lib')
-rw-r--r--spec/lib/gitlab/metrics/sidekiq_metrics_exporter_spec.rb4
1 files changed, 3 insertions, 1 deletions
diff --git a/spec/lib/gitlab/metrics/sidekiq_metrics_exporter_spec.rb b/spec/lib/gitlab/metrics/sidekiq_metrics_exporter_spec.rb
index 6721e02fb85..61eb059a731 100644
--- a/spec/lib/gitlab/metrics/sidekiq_metrics_exporter_spec.rb
+++ b/spec/lib/gitlab/metrics/sidekiq_metrics_exporter_spec.rb
@@ -38,7 +38,9 @@ describe Gitlab::Metrics::SidekiqMetricsExporter do
expect(::WEBrick::HTTPServer).to have_received(:new).with(
Port: port,
- BindAddress: address
+ BindAddress: address,
+ Logger: anything,
+ AccessLog: anything
)
end
end