diff options
author | GitLab Bot <gitlab-bot@gitlab.com> | 2020-01-31 15:08:42 +0000 |
---|---|---|
committer | GitLab Bot <gitlab-bot@gitlab.com> | 2020-01-31 15:08:42 +0000 |
commit | c27acb1d376f7127cd33eadcc8f5683ed55262bc (patch) | |
tree | 685c31391dca71a73782b5c8626f4ef5b582dc21 /spec/lib | |
parent | 1808454313ed75c92e1384466e8c83bfbc8ae25e (diff) | |
download | gitlab-ce-c27acb1d376f7127cd33eadcc8f5683ed55262bc.tar.gz |
Add latest changes from gitlab-org/gitlab@master
Diffstat (limited to 'spec/lib')
-rw-r--r-- | spec/lib/gitlab/background_migration/update_existing_subgroup_to_match_visibility_level_of_parent_spec.rb | 46 | ||||
-rw-r--r-- | spec/lib/gitlab/database/with_lock_retries_spec.rb | 19 |
2 files changed, 65 insertions, 0 deletions
diff --git a/spec/lib/gitlab/background_migration/update_existing_subgroup_to_match_visibility_level_of_parent_spec.rb b/spec/lib/gitlab/background_migration/update_existing_subgroup_to_match_visibility_level_of_parent_spec.rb new file mode 100644 index 00000000000..37280110b91 --- /dev/null +++ b/spec/lib/gitlab/background_migration/update_existing_subgroup_to_match_visibility_level_of_parent_spec.rb @@ -0,0 +1,46 @@ +# frozen_string_literal: true + +require 'spec_helper' + +describe Gitlab::BackgroundMigration::UpdateExistingSubgroupToMatchVisibilityLevelOfParent, :migration, schema: 2020_01_10_121314 do + include MigrationHelpers::NamespacesHelpers + + context 'private visibility level' do + it 'updates the project visibility' do + parent = create_namespace('parent', Gitlab::VisibilityLevel::PRIVATE) + child = create_namespace('child', Gitlab::VisibilityLevel::PUBLIC, parent_id: parent.id) + + expect { subject.perform([parent.id], Gitlab::VisibilityLevel::PRIVATE) }.to change { child.reload.visibility_level }.to(Gitlab::VisibilityLevel::PRIVATE) + end + + it 'updates sub-sub groups' do + parent = create_namespace('parent', Gitlab::VisibilityLevel::PRIVATE) + middle_group = create_namespace('middle', Gitlab::VisibilityLevel::PRIVATE, parent_id: parent.id) + child = create_namespace('child', Gitlab::VisibilityLevel::PUBLIC, parent_id: middle_group.id) + + subject.perform([parent.id, middle_group.id], Gitlab::VisibilityLevel::PRIVATE) + + expect(child.reload.visibility_level).to eq(Gitlab::VisibilityLevel::PRIVATE) + end + + it 'updates all sub groups' do + parent = create_namespace('parent', Gitlab::VisibilityLevel::PRIVATE) + middle_group = create_namespace('middle', Gitlab::VisibilityLevel::PUBLIC, parent_id: parent.id) + child = create_namespace('child', Gitlab::VisibilityLevel::PUBLIC, parent_id: middle_group.id) + + subject.perform([parent.id], Gitlab::VisibilityLevel::PRIVATE) + + expect(child.reload.visibility_level).to eq(Gitlab::VisibilityLevel::PRIVATE) + expect(middle_group.reload.visibility_level).to eq(Gitlab::VisibilityLevel::PRIVATE) + end + end + + context 'internal visibility level' do + it 'updates the project visibility' do + parent = create_namespace('parent', Gitlab::VisibilityLevel::INTERNAL) + child = create_namespace('child', Gitlab::VisibilityLevel::PUBLIC, parent_id: parent.id) + + expect { subject.perform([parent.id], Gitlab::VisibilityLevel::INTERNAL) }.to change { child.reload.visibility_level }.to(Gitlab::VisibilityLevel::INTERNAL) + end + end +end diff --git a/spec/lib/gitlab/database/with_lock_retries_spec.rb b/spec/lib/gitlab/database/with_lock_retries_spec.rb index c3be6510584..b6321f2eab1 100644 --- a/spec/lib/gitlab/database/with_lock_retries_spec.rb +++ b/spec/lib/gitlab/database/with_lock_retries_spec.rb @@ -128,4 +128,23 @@ describe Gitlab::Database::WithLockRetries do end end end + + context 'casting durations correctly' do + let(:timing_configuration) { [[0.015.seconds, 0.025.seconds], [0.015.seconds, 0.025.seconds]] } # 15ms, 25ms + + it 'executes `SET LOCAL lock_timeout` using the configured timeout value in milliseconds' do + expect(ActiveRecord::Base.connection).to receive(:execute).with("SAVEPOINT active_record_1").and_call_original + expect(ActiveRecord::Base.connection).to receive(:execute).with("SET LOCAL lock_timeout TO '15ms'").and_call_original + expect(ActiveRecord::Base.connection).to receive(:execute).with("RELEASE SAVEPOINT active_record_1").and_call_original + + subject.run { } + end + + it 'calls `sleep` after the first iteration fails, using the configured sleep time' do + expect(subject).to receive(:run_block_with_transaction).and_raise(ActiveRecord::LockWaitTimeout).twice + expect(subject).to receive(:sleep).with(0.025) + + subject.run { } + end + end end |