diff options
author | Douwe Maan <douwe@selenight.nl> | 2018-12-20 15:26:07 +0100 |
---|---|---|
committer | Douwe Maan <douwe@selenight.nl> | 2018-12-20 16:40:52 +0100 |
commit | ff5dace7bbb7674ef6fc3d630daf9c3ce7cc8bfa (patch) | |
tree | 448a3343f1f10b913cbc7af6ddb81c14a2ed69b6 /spec/mailers | |
parent | 34611f0dcded00b6878e72e07b45c416a0533b81 (diff) | |
download | gitlab-ce-ff5dace7bbb7674ef6fc3d630daf9c3ce7cc8bfa.tar.gz |
Always use colon at end of discussion notification email headline
Diffstat (limited to 'spec/mailers')
-rw-r--r-- | spec/mailers/notify_spec.rb | 12 |
1 files changed, 2 insertions, 10 deletions
diff --git a/spec/mailers/notify_spec.rb b/spec/mailers/notify_spec.rb index f6e5c9d33ac..f2d99872401 100644 --- a/spec/mailers/notify_spec.rb +++ b/spec/mailers/notify_spec.rb @@ -890,22 +890,14 @@ describe Notify do shared_examples 'an email for a note on a diff discussion' do |model| let(:note) { create(model, author: note_author) } - context 'when note is on image' do + context 'when note is not on text' do before do - allow_any_instance_of(DiffDiscussion).to receive(:on_image?).and_return(true) + allow_any_instance_of(DiffDiscussion).to receive(:on_text?).and_return(false) end it 'does not include diffs with character-level highlighting' do is_expected.not_to have_body_text '<span class="p">}</span></span>' end - - it 'ends the intro with a dot' do - is_expected.to have_body_text "#{note.diff_file.file_path}</a>." - end - end - - it 'ends the intro with a colon' do - is_expected.to have_body_text "#{note.diff_file.file_path}</a>:" end it 'includes diffs with character-level highlighting' do |