diff options
| author | blackst0ne <blackst0ne.ru@gmail.com> | 2018-07-23 15:34:54 +1100 |
|---|---|---|
| committer | blackst0ne <blackst0ne.ru@gmail.com> | 2018-07-23 15:34:54 +1100 |
| commit | ddd2a25679f1d875332f603f115e25577b05a5a2 (patch) | |
| tree | 2fb343f92c44755dae2294d9a9d0013045c5501a /spec/migrations/schedule_merge_request_diff_migrations_spec.rb | |
| parent | dc7b4b7bb97ead6fca1eefad5f56c8db5db00f93 (diff) | |
| download | gitlab-ce-ddd2a25679f1d875332f603f115e25577b05a5a2.tar.gz | |
Replace 'Sidekiq::Testing.inline!' with 'perform_enqueued_jobs'
`perform_enqueued_jobs` is a Sidekiq method.
Using this method violates the Dependency inversion principle[0].
This commit replaces `perform_enqueued_jobs` with ActiveJob's abstract
method `perform_enqueued_jobs` in specs.
[0]: https://en.wikipedia.org/wiki/Dependency_inversion_principle
Diffstat (limited to 'spec/migrations/schedule_merge_request_diff_migrations_spec.rb')
| -rw-r--r-- | spec/migrations/schedule_merge_request_diff_migrations_spec.rb | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/spec/migrations/schedule_merge_request_diff_migrations_spec.rb b/spec/migrations/schedule_merge_request_diff_migrations_spec.rb index d230f064444..9f7e47bae0d 100644 --- a/spec/migrations/schedule_merge_request_diff_migrations_spec.rb +++ b/spec/migrations/schedule_merge_request_diff_migrations_spec.rb @@ -33,7 +33,7 @@ describe ScheduleMergeRequestDiffMigrations, :migration, :sidekiq do end it 'schedules background migrations' do - Sidekiq::Testing.inline! do + perform_enqueued_jobs do non_empty = 'st_commits IS NOT NULL OR st_diffs IS NOT NULL' expect(merge_request_diffs.where(non_empty).count).to eq 3 |