diff options
author | Lin Jen-Shin <godfat@godfat.org> | 2017-06-27 17:46:45 +0800 |
---|---|---|
committer | Lin Jen-Shin <godfat@godfat.org> | 2017-06-27 17:46:45 +0800 |
commit | 10e732d2bb1afff22a0549c74636641859cc3bde (patch) | |
tree | f93fe19cf9f6b1054201a0aea6f3bb7f2071b9e6 /spec/migrations | |
parent | 6ff162cfd911ccfeeabc8fd1516840b10a8f9700 (diff) | |
download | gitlab-ce-10e732d2bb1afff22a0549c74636641859cc3bde.tar.gz |
Rename instead of delete, feedback:
https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/12363#note_33449374
Diffstat (limited to 'spec/migrations')
-rw-r--r-- | spec/migrations/remove_duplicated_variable_spec.rb | 15 |
1 files changed, 12 insertions, 3 deletions
diff --git a/spec/migrations/remove_duplicated_variable_spec.rb b/spec/migrations/remove_duplicated_variable_spec.rb index 9a521a7d980..11096564dfa 100644 --- a/spec/migrations/remove_duplicated_variable_spec.rb +++ b/spec/migrations/remove_duplicated_variable_spec.rb @@ -1,7 +1,7 @@ require 'spec_helper' -require Rails.root.join('db', 'migrate', '20170622135451_remove_duplicated_variable.rb') +require Rails.root.join('db', 'migrate', '20170622135451_rename_duplicated_variable_key.rb') -describe RemoveDuplicatedVariable, :migration do +describe RenameDuplicatedVariableKey, :migration do let(:variables) { table(:ci_variables) } let(:projects) { table(:projects) } @@ -20,6 +20,15 @@ describe RemoveDuplicatedVariable, :migration do it 'correctly remove duplicated records with smaller id' do migrate! - expect(variables.pluck(:id)).to contain_exactly(1, 2, 6, 7, 8) + expect(variables.pluck(:id, :key)).to contain_exactly( + [1, 'key1'], + [2, 'key2'], + [3, 'keyX_3'], + [4, 'keyX_4'], + [5, 'keyY_5'], + [6, 'keyX'], + [7, 'key7'], + [8, 'keyY'] + ) end end |