Moves domain setting to Cluster setting

Changes domain field to be on the Cluster page show, removing it from
Auto DevOps setting. Also injects the new environment variable
KUBE_INGRESS_BASE_DOMAIN into kubernetes#predefined_variables.

Migration to move the information from ProjectAutoDevops#domain
to Clusters::Cluster#domain. As well as necessary modifications to qa
selectors

Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/52363

1 files changed, 100 insertions, 0 deletions

diff --git a/spec/migrations/migrate_auto_dev_ops_domain_to_cluster_domain_spec.rb b/spec/migrations/migrate_auto_dev_ops_domain_to_cluster_domain_spec.rb
new file mode 100644
index 00000000000..09013ee4bd0
--- /dev/null
+++ b/spec/migrations/migrate_auto_dev_ops_domain_to_cluster_domain_spec.rb
@@ -0,0 +1,100 @@
+# frozen_string_literal: true
+
+require 'spec_helper'
+require Rails.root.join('db', 'migrate', '20190129165720_migrate_auto_dev_ops_domain_to_cluster_domain.rb')
+
+describe MigrateAutoDevOpsDomainToClusterDomain, :migration do
+  include MigrationHelpers::ClusterHelpers
+
+  let(:migration) { described_class.new }
+  let(:project_auto_devops_table) { table(:project_auto_devops) }
+  let(:clusters_table) { table(:clusters) }
+  let(:cluster_projects_table) { table(:cluster_projects) }
+
+  # Following lets are needed by MigrationHelpers::ClusterHelpers
+  let(:cluster_kubernetes_namespaces_table) { table(:clusters_kubernetes_namespaces) }
+  let(:projects_table) { table(:projects) }
+  let(:namespaces_table) { table(:namespaces) }
+  let(:provider_gcp_table) { table(:cluster_providers_gcp) }
+  let(:platform_kubernetes_table) { table(:cluster_platforms_kubernetes) }
+
+  before do
+    setup_cluster_projects_with_domain(quantity: 20, domain: domain)
+  end
+
+  context 'with ProjectAutoDevOps with no domain' do
+    let(:domain) { nil }
+
+    it 'should not update cluster project' do
+      migrate!
+
+      expect(clusters_without_domain.count).to eq(clusters_table.count)
+    end
+  end
+
+  context 'with ProjectAutoDevOps with domain' do
+    let(:domain) { 'example-domain.com' }
+
+    it 'should update all cluster projects' do
+      migrate!
+
+      expect(clusters_with_domain.count).to eq(clusters_table.count)
+    end
+  end
+
+  context 'when only some ProjectAutoDevOps have domain set' do
+    let(:domain) { 'example-domain.com' }
+
+    before do
+      setup_cluster_projects_with_domain(quantity: 20, domain: nil)
+    end
+
+    it 'should only update specific cluster projects' do
+      migrate!
+
+      project_auto_devops_with_domain.each do |project_auto_devops|
+        cluster_project = Clusters::Project.find_by(project_id: project_auto_devops.project_id)
+        cluster = Clusters::Cluster.find(cluster_project.cluster_id)
+
+        expect(cluster.domain).to be_present
+      end
+
+      project_auto_devops_without_domain.each do |project_auto_devops|
+        cluster_project = Clusters::Project.find_by(project_id: project_auto_devops.project_id)
+        cluster = Clusters::Cluster.find(cluster_project.cluster_id)
+
+        expect(cluster.domain).not_to be_present
+      end
+    end
+  end
+
+  def setup_cluster_projects_with_domain(quantity:, domain:)
+    create_cluster_project_list(quantity)
+
+    cluster_projects = cluster_projects_table.last(quantity)
+
+    cluster_projects.each do |cluster_project|
+      project_auto_devops_table.create(
+        project_id: cluster_project.project_id,
+        enabled: true,
+        domain: domain
+      )
+    end
+  end
+
+  def project_auto_devops_with_domain
+    project_auto_devops_table.where.not("domain IS NULL OR domain = ''")
+  end
+
+  def project_auto_devops_without_domain
+    project_auto_devops_table.where("domain IS NULL OR domain = ''")
+  end
+
+  def clusters_with_domain
+    clusters_table.where.not("domain IS NULL OR domain = ''")
+  end
+
+  def clusters_without_domain
+    clusters_table.where("domain IS NULL OR domain = ''")
+  end
+end