diff options
author | Nick Thomas <nick@gitlab.com> | 2019-07-03 09:19:17 +0000 |
---|---|---|
committer | Nick Thomas <nick@gitlab.com> | 2019-07-03 09:19:17 +0000 |
commit | e555db6f28260e5473b8634fe3a21e89ec1ba578 (patch) | |
tree | 3038ae4889bf9d2b017ca14488a0d949ea52cf42 /spec/migrations | |
parent | f90a7601c40c82bd230f9c014bc4f64744e77b5e (diff) | |
parent | 28ac2d304989164a1e9bf6d82fa8106a86a5f688 (diff) | |
download | gitlab-ce-e555db6f28260e5473b8634fe3a21e89ec1ba578.tar.gz |
Merge branch '44990-remove-old-i' into 'master'
Remove old migration specs that violate FactoriesInMigrationSpecs
See merge request gitlab-org/gitlab-ce!30280
Diffstat (limited to 'spec/migrations')
-rw-r--r-- | spec/migrations/remove_project_labels_group_id_spec.rb | 21 |
1 files changed, 0 insertions, 21 deletions
diff --git a/spec/migrations/remove_project_labels_group_id_spec.rb b/spec/migrations/remove_project_labels_group_id_spec.rb deleted file mode 100644 index 01b09e71d83..00000000000 --- a/spec/migrations/remove_project_labels_group_id_spec.rb +++ /dev/null @@ -1,21 +0,0 @@ -# encoding: utf-8 - -require 'spec_helper' -require Rails.root.join('db', 'post_migrate', '20180202111106_remove_project_labels_group_id.rb') - -describe RemoveProjectLabelsGroupId, :delete do - let(:migration) { described_class.new } - let(:group) { create(:group) } # rubocop:disable RSpec/FactoriesInMigrationSpecs - let!(:project_label) { create(:label, group_id: group.id) } # rubocop:disable RSpec/FactoriesInMigrationSpecs - let!(:group_label) { create(:group_label) } # rubocop:disable RSpec/FactoriesInMigrationSpecs - - describe '#up' do - it 'updates the project labels group ID' do - expect { migration.up }.to change { project_label.reload.group_id }.to(nil) - end - - it 'keeps the group labels group ID' do - expect { migration.up }.not_to change { group_label.reload.group_id } - end - end -end |