diff options
| author | Sean McGivern <sean@gitlab.com> | 2017-07-24 11:35:54 +0100 |
|---|---|---|
| committer | Sean McGivern <sean@gitlab.com> | 2017-07-24 16:58:04 +0100 |
| commit | ccac2abeba419f16029c40f29063f1812c9e159c (patch) | |
| tree | 975ca2e9f3fc91fae1ce0c775c8c267256fa7480 /spec/models/ability_spec.rb | |
| parent | f81ed493e1f02e5a197df3e2df9c5e42cb09e7ff (diff) | |
| download | gitlab-ce-ccac2abeba419f16029c40f29063f1812c9e159c.tar.gz | |
Don't treat anonymous users as owners when group has pending invites
The `members` table can have entries where `user_id: nil`, because people can
invite group members by email. We never want to include those as members,
because it might cause confusion with the anonymous (logged out) user.
Diffstat (limited to 'spec/models/ability_spec.rb')
| -rw-r--r-- | spec/models/ability_spec.rb | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/spec/models/ability_spec.rb b/spec/models/ability_spec.rb index dc7a0d80752..58f1a620ab4 100644 --- a/spec/models/ability_spec.rb +++ b/spec/models/ability_spec.rb @@ -98,7 +98,7 @@ describe Ability, lib: true do user2 = build(:user, external: true) users = [user1, user2] - expect(project).to receive(:owner).twice.and_return(user1) + expect(project).to receive(:owner).at_least(:once).and_return(user1) expect(described_class.users_that_can_read_project(users, project)) .to eq([user1]) @@ -109,7 +109,7 @@ describe Ability, lib: true do user2 = build(:user, external: true) users = [user1, user2] - expect(project.team).to receive(:members).twice.and_return([user1]) + expect(project.team).to receive(:members).at_least(:once).and_return([user1]) expect(described_class.users_that_can_read_project(users, project)) .to eq([user1]) @@ -140,7 +140,7 @@ describe Ability, lib: true do user2 = build(:user, external: true) users = [user1, user2] - expect(project).to receive(:owner).twice.and_return(user1) + expect(project).to receive(:owner).at_least(:once).and_return(user1) expect(described_class.users_that_can_read_project(users, project)) .to eq([user1]) @@ -151,7 +151,7 @@ describe Ability, lib: true do user2 = build(:user, external: true) users = [user1, user2] - expect(project.team).to receive(:members).twice.and_return([user1]) + expect(project.team).to receive(:members).at_least(:once).and_return([user1]) expect(described_class.users_that_can_read_project(users, project)) .to eq([user1]) |