diff options
| author | blackst0ne <blackst0ne.ru@gmail.com> | 2018-07-23 15:34:54 +1100 |
|---|---|---|
| committer | blackst0ne <blackst0ne.ru@gmail.com> | 2018-07-23 15:34:54 +1100 |
| commit | ddd2a25679f1d875332f603f115e25577b05a5a2 (patch) | |
| tree | 2fb343f92c44755dae2294d9a9d0013045c5501a /spec/models/ci | |
| parent | dc7b4b7bb97ead6fca1eefad5f56c8db5db00f93 (diff) | |
| download | gitlab-ce-ddd2a25679f1d875332f603f115e25577b05a5a2.tar.gz | |
Replace 'Sidekiq::Testing.inline!' with 'perform_enqueued_jobs'
`perform_enqueued_jobs` is a Sidekiq method.
Using this method violates the Dependency inversion principle[0].
This commit replaces `perform_enqueued_jobs` with ActiveJob's abstract
method `perform_enqueued_jobs` in specs.
[0]: https://en.wikipedia.org/wiki/Dependency_inversion_principle
Diffstat (limited to 'spec/models/ci')
| -rw-r--r-- | spec/models/ci/build_trace_chunk_spec.rb | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/spec/models/ci/build_trace_chunk_spec.rb b/spec/models/ci/build_trace_chunk_spec.rb index 774a638b430..915bf134d57 100644 --- a/spec/models/ci/build_trace_chunk_spec.rb +++ b/spec/models/ci/build_trace_chunk_spec.rb @@ -179,7 +179,7 @@ describe Ci::BuildTraceChunk, :clean_gitlab_redis_shared_state do end it 'migrates data to object storage' do - Sidekiq::Testing.inline! do + perform_enqueued_jobs do subject build_trace_chunk.reload @@ -201,7 +201,7 @@ describe Ci::BuildTraceChunk, :clean_gitlab_redis_shared_state do end it 'does not migrate data to object storage' do - Sidekiq::Testing.inline! do + perform_enqueued_jobs do data_store = build_trace_chunk.data_store subject |