diff options
author | Thong Kuah <tkuah@gitlab.com> | 2019-01-31 12:59:26 +1300 |
---|---|---|
committer | Thong Kuah <tkuah@gitlab.com> | 2019-02-07 00:07:49 +1300 |
commit | e72f24d27be911ffce943929b7ca2f6df7051083 (patch) | |
tree | 65aecff19acc8b833f158f94e33d1771a45e721d /spec/models/clusters/applications/prometheus_spec.rb | |
parent | 8ef1128f672266c789fc135500e1287ab389bb16 (diff) | |
download | gitlab-ce-e72f24d27be911ffce943929b7ca2f6df7051083.tar.gz |
Update version on :installed, not :installing
This makes this consistent with :updated. And also avoids a potential
issue where an install errors which means that that the recorded version
won't necessarily reflect the version that is actually installed.
Diffstat (limited to 'spec/models/clusters/applications/prometheus_spec.rb')
-rw-r--r-- | spec/models/clusters/applications/prometheus_spec.rb | 14 |
1 files changed, 0 insertions, 14 deletions
diff --git a/spec/models/clusters/applications/prometheus_spec.rb b/spec/models/clusters/applications/prometheus_spec.rb index e50ba67c493..36a6e4c347b 100644 --- a/spec/models/clusters/applications/prometheus_spec.rb +++ b/spec/models/clusters/applications/prometheus_spec.rb @@ -19,20 +19,6 @@ describe Clusters::Applications::Prometheus do it { is_expected.to contain_exactly(cluster) } end - describe '#make_installing!' do - before do - application.make_installing! - end - - context 'application install previously errored with older version' do - let(:application) { create(:clusters_applications_prometheus, :scheduled, version: '6.7.2') } - - it 'updates the application version' do - expect(application.reload.version).to eq('6.7.3') - end - end - end - describe 'transition to installed' do let(:project) { create(:project) } let(:cluster) { create(:cluster, :with_installed_helm, projects: [project]) } |