Speed up commit loads by disabling BatchLoader replace_methods

We've seen a significant performance penalty when using
`BatchLoader#__replace_with!`. This defines methods on the batch loader
that proxy to the 'real' object using send. The alternative is
`method_missing`, which is slower.  However, we've noticed that
`method_missing` can be faster if:

1. The objects being loaded have a large interface.
2. We don't call too many methods on the loaded object.

In production, we've seen the rendering times of the merge request
widget increase as a result of loading commit data. BatchLoader attempts
to call replace_methods on the lazy object, but this has a significant
performance penalty. Disabling this mode
(https://github.com/exAspArk/batch-loader/pull/45) appears to cut load
times by about 50% for MergeRequestsController#show.

Relates to https://gitlab.com/gitlab-com/gl-infra/infrastructure/issues/6941

1 files changed, 8 insertions, 0 deletions

diff --git a/spec/models/commit_spec.rb b/spec/models/commit_spec.rb
index 14f4b4d692f..e76186fb280 100644
--- a/spec/models/commit_spec.rb
+++ b/spec/models/commit_spec.rb
@@ -44,6 +44,14 @@ describe Commit do
           expect(commit.id).to eq(oids[i])
         end
       end
+
+      it 'does not attempt to replace methods via BatchLoader' do
+        subject.each do |commit|
+          expect(commit).to receive(:method_missing).and_call_original
+
+          commit.id
+        end
+      end
     end
 
     context 'when not found' do