summaryrefslogtreecommitdiff
path: root/spec/models/concerns/resolvable_note_spec.rb
diff options
context:
space:
mode:
authorSean McGivern <sean@gitlab.com>2017-09-05 18:51:08 +0100
committerSean McGivern <sean@gitlab.com>2017-09-06 10:10:16 +0100
commitb40941db14091bce20fd5edc9bb04b82a7eb21b9 (patch)
tree68b8309a9f2f07ff75c0486f274261393005fb6f /spec/models/concerns/resolvable_note_spec.rb
parent007b325dedd15a3042e87fc914d14bcae2794593 (diff)
downloadgitlab-ce-b40941db14091bce20fd5edc9bb04b82a7eb21b9.tar.gz
Fix note resolution specs
Diffstat (limited to 'spec/models/concerns/resolvable_note_spec.rb')
-rw-r--r--spec/models/concerns/resolvable_note_spec.rb16
1 files changed, 8 insertions, 8 deletions
diff --git a/spec/models/concerns/resolvable_note_spec.rb b/spec/models/concerns/resolvable_note_spec.rb
index d00faa4f8be..91591017587 100644
--- a/spec/models/concerns/resolvable_note_spec.rb
+++ b/spec/models/concerns/resolvable_note_spec.rb
@@ -189,8 +189,8 @@ describe Note, ResolvableNote do
allow(subject).to receive(:resolvable?).and_return(false)
end
- it "returns nil" do
- expect(subject.resolve!(current_user)).to be_nil
+ it "returns false" do
+ expect(subject.resolve!(current_user)).to be_falsey
end
it "doesn't set resolved_at" do
@@ -224,8 +224,8 @@ describe Note, ResolvableNote do
subject.resolve!(user)
end
- it "returns nil" do
- expect(subject.resolve!(current_user)).to be_nil
+ it "returns false" do
+ expect(subject.resolve!(current_user)).to be_falsey
end
it "doesn't change resolved_at" do
@@ -279,8 +279,8 @@ describe Note, ResolvableNote do
allow(subject).to receive(:resolvable?).and_return(false)
end
- it "returns nil" do
- expect(subject.unresolve!).to be_nil
+ it "returns false" do
+ expect(subject.unresolve!).to be_falsey
end
end
@@ -320,8 +320,8 @@ describe Note, ResolvableNote do
end
context "when not resolved" do
- it "returns nil" do
- expect(subject.unresolve!).to be_nil
+ it "returns false" do
+ expect(subject.unresolve!).to be_falsey
end
end
end