diff options
| author | Rémy Coutable <remy@rymai.me> | 2017-03-23 14:08:39 +0100 |
|---|---|---|
| committer | Rémy Coutable <remy@rymai.me> | 2017-04-03 18:54:48 +0200 |
| commit | 4e3516788fdea3de3c5f06e1981ddc518b05d0fb (patch) | |
| tree | d83183c2dfb8c5082a9d5a9fbcda6a5479c7d9fd /spec/models/cycle_analytics | |
| parent | ca6a7f1e9c9296317315249de9b8b3803d1c6ddc (diff) | |
| download | gitlab-ce-4e3516788fdea3de3c5f06e1981ddc518b05d0fb.tar.gz | |
Don't use FFaker in factories, use sequences instead
FFaker can generate data that randomly break our test suite. This
simplifies our factories and use sequences which are more predictive.
Signed-off-by: Rémy Coutable <remy@rymai.me>
Diffstat (limited to 'spec/models/cycle_analytics')
| -rw-r--r-- | spec/models/cycle_analytics/plan_spec.rb | 4 | ||||
| -rw-r--r-- | spec/models/cycle_analytics/production_spec.rb | 2 | ||||
| -rw-r--r-- | spec/models/cycle_analytics/staging_spec.rb | 2 |
3 files changed, 4 insertions, 4 deletions
diff --git a/spec/models/cycle_analytics/plan_spec.rb b/spec/models/cycle_analytics/plan_spec.rb index 55483fc876a..4f33f3c6d69 100644 --- a/spec/models/cycle_analytics/plan_spec.rb +++ b/spec/models/cycle_analytics/plan_spec.rb @@ -13,7 +13,7 @@ describe 'CycleAnalytics#plan', feature: true do data_fn: -> (context) do { issue: context.create(:issue, project: context.project), - branch_name: context.random_git_name + branch_name: context.generate(:branch) } end, start_time_conditions: [["issue associated with a milestone", @@ -35,7 +35,7 @@ describe 'CycleAnalytics#plan', feature: true do context "when a regular label (instead of a list label) is added to the issue" do it "returns nil" do - branch_name = random_git_name + branch_name = generate(:branch) label = create(:label) issue = create(:issue, project: project) issue.update(label_ids: [label.id]) diff --git a/spec/models/cycle_analytics/production_spec.rb b/spec/models/cycle_analytics/production_spec.rb index e6a826a9418..4744b9e05ea 100644 --- a/spec/models/cycle_analytics/production_spec.rb +++ b/spec/models/cycle_analytics/production_spec.rb @@ -23,7 +23,7 @@ describe 'CycleAnalytics#production', feature: true do # Make other changes on master sha = context.project.repository.create_file( context.user, - context.random_git_name, + context.generate(:branch), 'content', message: 'commit message', branch_name: 'master') diff --git a/spec/models/cycle_analytics/staging_spec.rb b/spec/models/cycle_analytics/staging_spec.rb index 3a02ed81adb..f78d7a23105 100644 --- a/spec/models/cycle_analytics/staging_spec.rb +++ b/spec/models/cycle_analytics/staging_spec.rb @@ -28,7 +28,7 @@ describe 'CycleAnalytics#staging', feature: true do # Make other changes on master sha = context.project.repository.create_file( context.user, - context.random_git_name, + context.generate(:branch), 'content', message: 'commit message', branch_name: 'master') |