diff options
author | Stan Hu <stanhu@gmail.com> | 2019-05-21 14:07:37 -0700 |
---|---|---|
committer | Stan Hu <stanhu@gmail.com> | 2019-05-21 23:19:07 -0700 |
commit | 37a335e60edd4f4c8b61fd2f9ffe0f1d27e3bfb8 (patch) | |
tree | 1e1d0aad5fdfe0ba1a9cecae6c402313b7be5c54 /spec/models/environment_spec.rb | |
parent | d707e2a49f2efe4670b5ebe62fb61554640ca7e9 (diff) | |
download | gitlab-ce-37a335e60edd4f4c8b61fd2f9ffe0f1d27e3bfb8.tar.gz |
Fix remaining failures in shoulda-matcher
Starting with Rails 5, belongs_to now adds a presence validation to the
association, and so as of shoulda-matchers 4.0.0 the belong_to matcher
follows suit and tests that this validation is there by setting the
association to nil and asserting that there are validation errors. This
exposed an error with the `validate_branches` method: we need to check
the source and target project exist.
Diffstat (limited to 'spec/models/environment_spec.rb')
-rw-r--r-- | spec/models/environment_spec.rb | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/spec/models/environment_spec.rb b/spec/models/environment_spec.rb index 17246f238e0..7233d2454c6 100644 --- a/spec/models/environment_spec.rb +++ b/spec/models/environment_spec.rb @@ -6,7 +6,7 @@ describe Environment do let(:project) { create(:project, :stubbed_repository) } subject(:environment) { create(:environment, project: project) } - it { is_expected.to belong_to(:project) } + it { is_expected.to belong_to(:project).required } it { is_expected.to have_many(:deployments) } it { is_expected.to delegate_method(:stop_action).to(:last_deployment) } |