Service for calling Sentry issues api

1 files changed, 82 insertions, 9 deletions

diff --git a/spec/models/error_tracking/project_error_tracking_setting_spec.rb b/spec/models/error_tracking/project_error_tracking_setting_spec.rb
index 83f29718eda..2f8ab21d4b2 100644
--- a/spec/models/error_tracking/project_error_tracking_setting_spec.rb
+++ b/spec/models/error_tracking/project_error_tracking_setting_spec.rb
@@ -3,33 +3,106 @@
 require 'spec_helper'
 
 describe ErrorTracking::ProjectErrorTrackingSetting do
+  include ReactiveCachingHelpers
+
   set(:project) { create(:project) }
 
+  subject { create(:project_error_tracking_setting, project: project) }
+
   describe 'Associations' do
     it { is_expected.to belong_to(:project) }
   end
 
   describe 'Validations' do
-    subject { create(:project_error_tracking_setting, project: project) }
-
     context 'when api_url is over 255 chars' do
-      before do
+      it 'fails validation' do
         subject.api_url = 'https://' + 'a' * 250
-      end
 
-      it 'fails validation' do
         expect(subject).not_to be_valid
         expect(subject.errors.messages[:api_url]).to include('is too long (maximum is 255 characters)')
       end
     end
 
     context 'With unsafe url' do
-      let(:project_error_tracking_setting) { create(:project_error_tracking_setting, project: project) }
-
       it 'fails validation' do
-        project_error_tracking_setting.api_url = "https://replaceme.com/'><script>alert(document.cookie)</script>"
+        subject.api_url = "https://replaceme.com/'><script>alert(document.cookie)</script>"
+
+        expect(subject).not_to be_valid
+      end
+    end
+
+    context 'URL path' do
+      it 'fails validation with wrong path' do
+        subject.api_url = 'http://gitlab.com/project1/something'
+
+        expect(subject).not_to be_valid
+        expect(subject.errors.messages[:api_url]).to include('path needs to start with /api/0/projects')
+      end
+
+      it 'passes validation with correct path' do
+        subject.api_url = 'http://gitlab.com/api/0/projects/project1/something'
+
+        expect(subject).to be_valid
+      end
+    end
+  end
+
+  describe '#sentry_external_url' do
+    let(:sentry_url) { 'https://sentrytest.gitlab.com/api/0/projects/sentry-org/sentry-project' }
+
+    before do
+      subject.api_url = sentry_url
+    end
+
+    it 'returns the correct url' do
+      expect(subject.class).to receive(:extract_sentry_external_url).with(sentry_url).and_call_original
+
+      result = subject.sentry_external_url
+
+      expect(result).to eq('https://sentrytest.gitlab.com/sentry-org/sentry-project')
+    end
+  end
+
+  describe '#sentry_client' do
+    it 'returns sentry client' do
+      expect(subject.sentry_client).to be_a(Sentry::Client)
+    end
+  end
+
+  describe '#list_sentry_issues' do
+    let(:issues) { [:list, :of, :issues] }
+
+    let(:opts) do
+      { issue_status: 'unresolved', limit: 10 }
+    end
+
+    let(:result) do
+      subject.list_sentry_issues(**opts)
+    end
+
+    context 'when cached' do
+      let(:sentry_client) { spy(:sentry_client) }
+
+      before do
+        stub_reactive_cache(subject, issues, opts)
+        synchronous_reactive_cache(subject)
+
+        expect(subject).to receive(:sentry_client).and_return(sentry_client)
+      end
+
+      it 'returns cached issues' do
+        expect(sentry_client).to receive(:list_issues).with(opts)
+          .and_return(issues)
+
+        expect(result).to eq(issues: issues)
+      end
+    end
+
+    context 'when not cached' do
+      it 'returns nil' do
+        expect(subject).not_to receive(:sentry_client)
 
-        expect(project_error_tracking_setting).not_to be_valid
+        expect(result).to be_nil
       end
     end
   end