diff options
author | Douwe Maan <douwe@gitlab.com> | 2017-11-09 15:40:41 +0000 |
---|---|---|
committer | Rémy Coutable <remy@rymai.me> | 2017-11-09 15:40:41 +0000 |
commit | 2fbbba9a2958d51f9a6d8e0a7c4e06ec95ae18c0 (patch) | |
tree | 7db653ce366b6d2e96997675dc7911e5dabb0bec /spec/models/group_spec.rb | |
parent | 9a56496d4441569001d11572d74822ea0cb3e7eb (diff) | |
download | gitlab-ce-2fbbba9a2958d51f9a6d8e0a7c4e06ec95ae18c0.tar.gz |
Always return full avatar URL for private/internal groups/projects when asset host is set
Diffstat (limited to 'spec/models/group_spec.rb')
-rw-r--r-- | spec/models/group_spec.rb | 10 |
1 files changed, 2 insertions, 8 deletions
diff --git a/spec/models/group_spec.rb b/spec/models/group_spec.rb index d4052a64570..5e82a2988ce 100644 --- a/spec/models/group_spec.rb +++ b/spec/models/group_spec.rb @@ -247,8 +247,6 @@ describe Group do describe '#avatar_url' do let!(:group) { create(:group, :access_requestable, :with_avatar) } let(:user) { create(:user) } - let(:gitlab_host) { "http://#{Gitlab.config.gitlab.host}" } - let(:avatar_path) { "/uploads/-/system/group/avatar/#{group.id}/dk.png" } context 'when avatar file is uploaded' do before do @@ -256,12 +254,8 @@ describe Group do end it 'shows correct avatar url' do - expect(group.avatar_url).to eq(avatar_path) - expect(group.avatar_url(only_path: false)).to eq([gitlab_host, avatar_path].join) - - allow(ActionController::Base).to receive(:asset_host).and_return(gitlab_host) - - expect(group.avatar_url).to eq([gitlab_host, avatar_path].join) + expect(group.avatar_url).to eq(group.avatar.url) + expect(group.avatar_url(only_path: false)).to eq([Gitlab.config.gitlab.url, group.avatar.url].join) end end end |