Merge branch '58886-issue-tracker-fields' into 'master'

Create models for issue trackers data

See merge request gitlab-org/gitlab-ce!28598

2 files changed, 77 insertions, 0 deletions

diff --git a/spec/models/project_services/issue_tracker_data_spec.rb b/spec/models/project_services/issue_tracker_data_spec.rb
new file mode 100644
index 00000000000..aaab654f874
--- /dev/null
+++ b/spec/models/project_services/issue_tracker_data_spec.rb
@@ -0,0 +1,35 @@
+# frozen_string_literal: true
+
+require 'spec_helper'
+
+describe IssueTrackerData do
+  let(:service) { create(:custom_issue_tracker_service, active: false, properties: {}) }
+
+  describe 'Associations' do
+    it { is_expected.to belong_to :service }
+  end
+
+  describe 'Validations' do
+    subject { described_class.new(service: service) }
+
+    context 'url validations' do
+      context 'when service is inactive' do
+        it { is_expected.not_to validate_presence_of(:project_url) }
+        it { is_expected.not_to validate_presence_of(:issues_url) }
+      end
+
+      context 'when service is active' do
+        before do
+          service.update(active: true)
+        end
+
+        it_behaves_like 'issue tracker service URL attribute', :project_url
+        it_behaves_like 'issue tracker service URL attribute', :issues_url
+        it_behaves_like 'issue tracker service URL attribute', :new_issue_url
+
+        it { is_expected.to validate_presence_of(:project_url) }
+        it { is_expected.to validate_presence_of(:issues_url) }
+      end
+    end
+  end
+end
diff --git a/spec/models/project_services/jira_tracker_data_spec.rb b/spec/models/project_services/jira_tracker_data_spec.rb
new file mode 100644
index 00000000000..1b6ece8531b
--- /dev/null
+++ b/spec/models/project_services/jira_tracker_data_spec.rb
@@ -0,0 +1,42 @@
+# frozen_string_literal: true
+
+require 'spec_helper'
+
+describe JiraTrackerData do
+  let(:service) { create(:jira_service, active: false, properties: {}) }
+
+  describe 'Associations' do
+    it { is_expected.to belong_to(:service) }
+  end
+
+  describe 'Validations' do
+    subject { described_class.new(service: service) }
+
+    context 'jira_issue_transition_id' do
+      it { is_expected.to allow_value(nil).for(:jira_issue_transition_id) }
+      it { is_expected.to allow_value('1,2,3').for(:jira_issue_transition_id) }
+      it { is_expected.to allow_value('1;2;3').for(:jira_issue_transition_id) }
+      it { is_expected.not_to allow_value('a,b,cd').for(:jira_issue_transition_id) }
+    end
+
+    context 'url validations' do
+      context 'when service is inactive' do
+        it { is_expected.not_to validate_presence_of(:url) }
+        it { is_expected.not_to validate_presence_of(:username) }
+        it { is_expected.not_to validate_presence_of(:password) }
+      end
+
+      context 'when service is active' do
+        before do
+          service.update(active: true)
+        end
+
+        it_behaves_like 'issue tracker service URL attribute', :url
+
+        it { is_expected.to validate_presence_of(:url) }
+        it { is_expected.to validate_presence_of(:username) }
+        it { is_expected.to validate_presence_of(:password) }
+      end
+    end
+  end
+end