summaryrefslogtreecommitdiff
path: root/spec/models/remote_mirror_spec.rb
diff options
context:
space:
mode:
authorFrancisco Javier López <fjlopez@gitlab.com>2018-12-10 17:23:52 +0100
committerFrancisco Javier López <fjlopez@gitlab.com>2018-12-13 08:57:04 +0100
commit63c48f73803cf1c68d6c9af408f877ea61781118 (patch)
tree6d0dfb44b84e618d51cda7d5dd8cac98cdc2050f /spec/models/remote_mirror_spec.rb
parent5c5a5992c0602f14c7f4f43b5fc2756662fafb3c (diff)
downloadgitlab-ce-63c48f73803cf1c68d6c9af408f877ea61781118.tar.gz
Replaced UrlValidator with PublicUrlValidator for import_url and remote mirror urls
Diffstat (limited to 'spec/models/remote_mirror_spec.rb')
-rw-r--r--spec/models/remote_mirror_spec.rb14
1 files changed, 14 insertions, 0 deletions
diff --git a/spec/models/remote_mirror_spec.rb b/spec/models/remote_mirror_spec.rb
index b12ca79847c..66a25ccb410 100644
--- a/spec/models/remote_mirror_spec.rb
+++ b/spec/models/remote_mirror_spec.rb
@@ -24,6 +24,20 @@ describe RemoteMirror do
expect(remote_mirror).to be_invalid
expect(remote_mirror.errors[:url].first).to include('Username needs to start with an alphanumeric character')
end
+
+ it 'does not allow url pointing to localhost' do
+ remote_mirror = build(:remote_mirror, url: 'http://127.0.0.2/t.git')
+
+ expect(remote_mirror).to be_invalid
+ expect(remote_mirror.errors[:url].first).to include('Requests to loopback addresses are not allowed')
+ end
+
+ it 'does not allow url pointing to the local network' do
+ remote_mirror = build(:remote_mirror, url: 'https://192.168.1.1')
+
+ expect(remote_mirror).to be_invalid
+ expect(remote_mirror.errors[:url].first).to include('Requests to the local network are not allowed')
+ end
end
end