diff options
author | Robert Speicher <robert@gitlab.com> | 2017-04-04 01:22:39 +0000 |
---|---|---|
committer | Robert Speicher <robert@gitlab.com> | 2017-04-04 01:22:39 +0000 |
commit | fa65b65b0f5e7095e2ec7c4ca0c269a4fe4baab1 (patch) | |
tree | 8ffa5d883b3723fb9529dd7c6806c00daf5621ca /spec/models/repository_spec.rb | |
parent | 2fd089a22d3555edc4fcdbd1e9400739dbfe35f1 (diff) | |
parent | bf69e6291d7c7029c18f21a65abc2579e1825cb0 (diff) | |
download | gitlab-ce-fa65b65b0f5e7095e2ec7c4ca0c269a4fe4baab1.tar.gz |
Merge branch '29643-stop-using-ffaker-in-factories' into 'master'
Don't use FFaker in factories, use sequences instead
Closes #29643
See merge request !10184
Diffstat (limited to 'spec/models/repository_spec.rb')
-rw-r--r-- | spec/models/repository_spec.rb | 17 |
1 files changed, 2 insertions, 15 deletions
diff --git a/spec/models/repository_spec.rb b/spec/models/repository_spec.rb index b16848f6f4f..d805e65b3c6 100644 --- a/spec/models/repository_spec.rb +++ b/spec/models/repository_spec.rb @@ -24,21 +24,8 @@ describe Repository, models: true do repository.commit(merge_commit_id) end - let(:author_email) { FFaker::Internet.email } - - # I have to remove periods from the end of the name - # This happened when the user's name had a suffix (i.e. "Sr.") - # This seems to be what git does under the hood. For example, this commit: - # - # $ git commit --author='Foo Sr. <foo@example.com>' -m 'Where's my trailing period?' - # - # results in this: - # - # $ git show --pretty - # ... - # Author: Foo Sr <foo@example.com> - # ... - let(:author_name) { FFaker::Name.name.chomp("\.") } + let(:author_email) { 'user@example.org' } + let(:author_name) { 'John Doe' } describe '#branch_names_contains' do subject { repository.branch_names_contains(sample_commit.id) } |