summaryrefslogtreecommitdiff
path: root/spec/models
diff options
context:
space:
mode:
authorJarka Košanová <jarka@gitlab.com>2019-05-22 16:47:42 +0100
committerJarka Košanová <jarka@gitlab.com>2019-06-13 19:02:13 +0200
commit1f332ae8da994509232c7601074b25514ad23c52 (patch)
tree91d0facea9e413baa568caf6af406a0fdef823b8 /spec/models
parent07f8f2056d7143c770d420ec3345781802047810 (diff)
downloadgitlab-ce-1f332ae8da994509232c7601074b25514ad23c52.tar.gz
Create models for issue trackers data58886-issue-tracker-fields
- create tables for storing issue trackers properties - add model and basic logic & spec
Diffstat (limited to 'spec/models')
-rw-r--r--spec/models/project_services/issue_tracker_data_spec.rb35
-rw-r--r--spec/models/project_services/jira_tracker_data_spec.rb42
-rw-r--r--spec/models/service_spec.rb2
3 files changed, 79 insertions, 0 deletions
diff --git a/spec/models/project_services/issue_tracker_data_spec.rb b/spec/models/project_services/issue_tracker_data_spec.rb
new file mode 100644
index 00000000000..aaab654f874
--- /dev/null
+++ b/spec/models/project_services/issue_tracker_data_spec.rb
@@ -0,0 +1,35 @@
+# frozen_string_literal: true
+
+require 'spec_helper'
+
+describe IssueTrackerData do
+ let(:service) { create(:custom_issue_tracker_service, active: false, properties: {}) }
+
+ describe 'Associations' do
+ it { is_expected.to belong_to :service }
+ end
+
+ describe 'Validations' do
+ subject { described_class.new(service: service) }
+
+ context 'url validations' do
+ context 'when service is inactive' do
+ it { is_expected.not_to validate_presence_of(:project_url) }
+ it { is_expected.not_to validate_presence_of(:issues_url) }
+ end
+
+ context 'when service is active' do
+ before do
+ service.update(active: true)
+ end
+
+ it_behaves_like 'issue tracker service URL attribute', :project_url
+ it_behaves_like 'issue tracker service URL attribute', :issues_url
+ it_behaves_like 'issue tracker service URL attribute', :new_issue_url
+
+ it { is_expected.to validate_presence_of(:project_url) }
+ it { is_expected.to validate_presence_of(:issues_url) }
+ end
+ end
+ end
+end
diff --git a/spec/models/project_services/jira_tracker_data_spec.rb b/spec/models/project_services/jira_tracker_data_spec.rb
new file mode 100644
index 00000000000..1b6ece8531b
--- /dev/null
+++ b/spec/models/project_services/jira_tracker_data_spec.rb
@@ -0,0 +1,42 @@
+# frozen_string_literal: true
+
+require 'spec_helper'
+
+describe JiraTrackerData do
+ let(:service) { create(:jira_service, active: false, properties: {}) }
+
+ describe 'Associations' do
+ it { is_expected.to belong_to(:service) }
+ end
+
+ describe 'Validations' do
+ subject { described_class.new(service: service) }
+
+ context 'jira_issue_transition_id' do
+ it { is_expected.to allow_value(nil).for(:jira_issue_transition_id) }
+ it { is_expected.to allow_value('1,2,3').for(:jira_issue_transition_id) }
+ it { is_expected.to allow_value('1;2;3').for(:jira_issue_transition_id) }
+ it { is_expected.not_to allow_value('a,b,cd').for(:jira_issue_transition_id) }
+ end
+
+ context 'url validations' do
+ context 'when service is inactive' do
+ it { is_expected.not_to validate_presence_of(:url) }
+ it { is_expected.not_to validate_presence_of(:username) }
+ it { is_expected.not_to validate_presence_of(:password) }
+ end
+
+ context 'when service is active' do
+ before do
+ service.update(active: true)
+ end
+
+ it_behaves_like 'issue tracker service URL attribute', :url
+
+ it { is_expected.to validate_presence_of(:url) }
+ it { is_expected.to validate_presence_of(:username) }
+ it { is_expected.to validate_presence_of(:password) }
+ end
+ end
+ end
+end
diff --git a/spec/models/service_spec.rb b/spec/models/service_spec.rb
index 64db32781fe..c9439b0846d 100644
--- a/spec/models/service_spec.rb
+++ b/spec/models/service_spec.rb
@@ -6,6 +6,8 @@ describe Service do
describe "Associations" do
it { is_expected.to belong_to :project }
it { is_expected.to have_one :service_hook }
+ it { is_expected.to have_one :jira_tracker_data }
+ it { is_expected.to have_one :issue_tracker_data }
end
describe 'Validations' do