diff options
author | Grzegorz Bizon <grzesiek.bizon@gmail.com> | 2018-03-30 10:32:28 +0200 |
---|---|---|
committer | Grzegorz Bizon <grzesiek.bizon@gmail.com> | 2018-03-30 10:32:28 +0200 |
commit | 0a203f408786ae2e28616a0e1bf488595f7f115b (patch) | |
tree | 945e99f5decf6e62dcd2b3b756204a7c5bae8096 /spec/models | |
parent | 1cc96d7a622cd754674ae8184268acf41a0be7d7 (diff) | |
download | gitlab-ce-0a203f408786ae2e28616a0e1bf488595f7f115b.tar.gz |
Improve naming and optimize methods of the build class
Diffstat (limited to 'spec/models')
-rw-r--r-- | spec/models/ci/build_spec.rb | 10 |
1 files changed, 5 insertions, 5 deletions
diff --git a/spec/models/ci/build_spec.rb b/spec/models/ci/build_spec.rb index 4b9ddb3c831..a12717835b0 100644 --- a/spec/models/ci/build_spec.rb +++ b/spec/models/ci/build_spec.rb @@ -2070,7 +2070,7 @@ describe Ci::Build do end end - describe '#variables_hash' do + describe '#scoped_variables_hash' do context 'when overriding secret variables' do before do project.variables.create!(key: 'MY_VAR', value: 'my value 1') @@ -2078,8 +2078,8 @@ describe Ci::Build do end it 'returns a regular hash created using valid ordering' do - expect(build.variables_hash).to include('MY_VAR': 'my value 2') - expect(build.variables_hash).not_to include('MY_VAR': 'my value 1') + expect(build.scoped_variables_hash).to include('MY_VAR': 'my value 2') + expect(build.scoped_variables_hash).not_to include('MY_VAR': 'my value 1') end end @@ -2090,8 +2090,8 @@ describe Ci::Build do end it 'returns a hash including variable with higher precedence' do - expect(build.variables_hash).to include('MY_VAR': 'pipeline value') - expect(build.variables_hash).not_to include('MY_VAR': 'myvar') + expect(build.scoped_variables_hash).to include('MY_VAR': 'pipeline value') + expect(build.scoped_variables_hash).not_to include('MY_VAR': 'myvar') end end end |