summaryrefslogtreecommitdiff
path: root/spec/observers
diff options
context:
space:
mode:
authorVincent Bonmalais <vb.kouno@gmail.com>2012-11-06 14:31:55 +1100
committerVincent Bonmalais <vb.kouno@gmail.com>2012-11-13 22:27:45 +1100
commit80fb38de7abdfacbf5ad2e0150b934c1392721f0 (patch)
tree302ee55b21e8206ab44cef819a583803b9bb0c6f /spec/observers
parentd52f06f38013540a9798686aa37c4dad120c3d74 (diff)
downloadgitlab-ce-80fb38de7abdfacbf5ad2e0150b934c1392721f0.tar.gz
Remove backward compatibility of factories.
Diffstat (limited to 'spec/observers')
-rw-r--r--spec/observers/activity_observer_spec.rb18
-rw-r--r--spec/observers/issue_observer_spec.rb4
-rw-r--r--spec/observers/merge_request_observer_spec.rb4
-rw-r--r--spec/observers/note_observer_spec.rb2
-rw-r--r--spec/observers/user_observer_spec.rb2
-rw-r--r--spec/observers/users_project_observer_spec.rb14
6 files changed, 22 insertions, 22 deletions
diff --git a/spec/observers/activity_observer_spec.rb b/spec/observers/activity_observer_spec.rb
index 0db4a9985be..0eec41f44e9 100644
--- a/spec/observers/activity_observer_spec.rb
+++ b/spec/observers/activity_observer_spec.rb
@@ -1,17 +1,17 @@
require 'spec_helper'
describe ActivityObserver do
- let(:project) { Factory :project }
+ let(:project) { create(:project) }
def self.it_should_be_valid_event
it { @event.should_not be_nil }
it { @event.project.should == project }
end
- describe "Merge Request created" do
+ describe "Merge Request created" do
before do
MergeRequest.observers.enable :activity_observer do
- @merge_request = Factory :merge_request, project: project
+ @merge_request = create(:merge_request, project: project)
@event = Event.last
end
end
@@ -21,10 +21,10 @@ describe ActivityObserver do
it { @event.target.should == @merge_request }
end
- describe "Issue created" do
+ describe "Issue created" do
before do
Issue.observers.enable :activity_observer do
- @issue = Factory :issue, project: project
+ @issue = create(:issue, project: project)
@event = Event.last
end
end
@@ -34,10 +34,10 @@ describe ActivityObserver do
it { @event.target.should == @issue }
end
- #describe "Issue commented" do
- #before do
- #@issue = Factory :issue, project: project
- #@note = Factory :note, noteable: @issue, project: project
+ #describe "Issue commented" do
+ #before do
+ #@issue = create(:issue, project: project)
+ #@note = create(:note, noteable: @issue, project: project)
#@event = Event.last
#end
diff --git a/spec/observers/issue_observer_spec.rb b/spec/observers/issue_observer_spec.rb
index b5943f2c539..509c1d02b49 100644
--- a/spec/observers/issue_observer_spec.rb
+++ b/spec/observers/issue_observer_spec.rb
@@ -16,7 +16,7 @@ describe IssueObserver do
subject.should_receive(:after_create)
Issue.observers.enable :issue_observer do
- Factory.create(:issue, project: Factory.create(:project))
+ create(:issue, project: create(:project))
end
end
@@ -43,7 +43,7 @@ describe IssueObserver do
end
it 'is called when an issue is changed' do
- changed = Factory.create(:issue, project: Factory.create(:project))
+ changed = create(:issue, project: create(:project))
subject.should_receive(:after_update)
Issue.observers.enable :issue_observer do
diff --git a/spec/observers/merge_request_observer_spec.rb b/spec/observers/merge_request_observer_spec.rb
index a9ba79271e3..6b15be96630 100644
--- a/spec/observers/merge_request_observer_spec.rb
+++ b/spec/observers/merge_request_observer_spec.rb
@@ -16,7 +16,7 @@ describe MergeRequestObserver do
subject.should_receive(:after_create)
MergeRequest.observers.enable :merge_request_observer do
- Factory.create(:merge_request, project: Factory.create(:project))
+ create(:merge_request, project: create(:project))
end
end
@@ -43,7 +43,7 @@ describe MergeRequestObserver do
end
it 'is called when a merge request is changed' do
- changed = Factory.create(:merge_request, project: Factory.create(:project))
+ changed = create(:merge_request, project: create(:project))
subject.should_receive(:after_update)
MergeRequest.observers.enable :merge_request_observer do
diff --git a/spec/observers/note_observer_spec.rb b/spec/observers/note_observer_spec.rb
index 203a58a4950..7dfa9f772e9 100644
--- a/spec/observers/note_observer_spec.rb
+++ b/spec/observers/note_observer_spec.rb
@@ -13,7 +13,7 @@ describe NoteObserver do
subject.should_receive :after_create
Note.observers.enable :note_observer do
- Factory.create(:note)
+ create(:note)
end
end
diff --git a/spec/observers/user_observer_spec.rb b/spec/observers/user_observer_spec.rb
index 0420a250c8a..08254f44026 100644
--- a/spec/observers/user_observer_spec.rb
+++ b/spec/observers/user_observer_spec.rb
@@ -4,7 +4,7 @@ describe UserObserver do
subject { UserObserver.instance }
it 'calls #after_create when new users are created' do
- new_user = Factory.new(:user)
+ new_user = build(:user)
subject.should_receive(:after_create).with(new_user)
User.observers.enable :user_observer do
diff --git a/spec/observers/users_project_observer_spec.rb b/spec/observers/users_project_observer_spec.rb
index a8e0834bc99..cbe42248033 100644
--- a/spec/observers/users_project_observer_spec.rb
+++ b/spec/observers/users_project_observer_spec.rb
@@ -1,13 +1,13 @@
require 'spec_helper'
describe UsersProjectObserver do
- let(:user) { Factory.create :user }
- let(:project) { Factory.create(:project,
- code: "Fuu",
- path: "Fuu" ) }
- let(:users_project) { Factory.create(:users_project,
- project: project,
- user: user )}
+ let(:user) { create(:user) }
+ let(:project) { create(:project,
+ code: "Fuu",
+ path: "Fuu" ) }
+ let(:users_project) { create(:users_project,
+ project: project,
+ user: user )}
subject { UsersProjectObserver.instance }
describe "#after_commit" do