diff options
author | Małgorzata Ksionek <meksionek@gmail.com> | 2019-03-12 12:33:45 +0100 |
---|---|---|
committer | Małgorzata Ksionek <meksionek@gmail.com> | 2019-03-12 12:33:45 +0100 |
commit | e285fb50498912c7fbabf5edfe64a9bedd85fc71 (patch) | |
tree | 41c9c6f322c8dad2f4094d1b767aa13951c6d610 /spec/policies | |
parent | e4b2c3b08b0aced417e072e60d5b299144c40474 (diff) | |
download | gitlab-ce-e285fb50498912c7fbabf5edfe64a9bedd85fc71.tar.gz |
Fix false positive specs
Diffstat (limited to 'spec/policies')
-rw-r--r-- | spec/policies/group_policy_spec.rb | 14 |
1 files changed, 12 insertions, 2 deletions
diff --git a/spec/policies/group_policy_spec.rb b/spec/policies/group_policy_spec.rb index 0ad50c6f91f..28fc7e0ddf5 100644 --- a/spec/policies/group_policy_spec.rb +++ b/spec/policies/group_policy_spec.rb @@ -80,6 +80,8 @@ describe GroupPolicy do let(:current_user) { nil } before do + group.add_developer(user) + Projects::GroupLinks::CreateService.new( project, user, @@ -87,7 +89,10 @@ describe GroupPolicy do ).execute(group) end - it { expect_disallowed(:read_group) } + it do + expect(group.shared_projects).not_to be_empty + expect_disallowed(:read_group) + end end context 'with foreign user and public project' do @@ -96,6 +101,8 @@ describe GroupPolicy do let(:current_user) { create(:user) } before do + group.add_developer(user) + Projects::GroupLinks::CreateService.new( project, user, @@ -103,7 +110,10 @@ describe GroupPolicy do ).execute(group) end - it { expect_disallowed(:read_group) } + it do + expect(group.shared_projects).not_to be_empty + expect_disallowed(:read_group) + end end context 'has projects' do |