summaryrefslogtreecommitdiff
path: root/spec/policies
diff options
context:
space:
mode:
authorMichael Kozono <mkozono@gmail.com>2017-09-05 23:05:25 -0700
committerMichael Kozono <mkozono@gmail.com>2017-09-06 12:07:21 -0700
commit5404dbb49d4064f7ff3b74ea229edb43f01fd699 (patch)
treebde022fe39ea0178a940d93d4b7ce2696fde1270 /spec/policies
parent45601cbadfd0af6a5ac4ac112129d839265ce3dd (diff)
downloadgitlab-ce-5404dbb49d4064f7ff3b74ea229edb43f01fd699.tar.gz
Fix ability when Share lock is off
Diffstat (limited to 'spec/policies')
-rw-r--r--spec/policies/group_policy_spec.rb104
1 files changed, 60 insertions, 44 deletions
diff --git a/spec/policies/group_policy_spec.rb b/spec/policies/group_policy_spec.rb
index fdf588f6455..0c4044dc7ab 100644
--- a/spec/policies/group_policy_spec.rb
+++ b/spec/policies/group_policy_spec.rb
@@ -244,76 +244,92 @@ describe GroupPolicy do
end
describe 'change_share_with_group_lock' do
- context 'when the group has a parent', :nested_groups do
- let(:group) { create(:group, parent: parent) }
+ context 'when the current_user owns the group' do
+ let(:current_user) { owner }
- context 'when the parent share_with_group_lock is enabled' do
- let(:current_user) { owner }
+ context 'when the group share_with_group_lock is enabled' do
+ let(:group) { create(:group, share_with_group_lock: true, parent: parent) }
- context 'when the group has a grandparent' do
- let(:grandparent) { create(:group, share_with_group_lock: true) }
- let(:parent) { create(:group, share_with_group_lock: true, parent: grandparent) }
+ context 'when the parent group share_with_group_lock is enabled' do
+ context 'when the group has a grandparent' do
+ let(:parent) { create(:group, share_with_group_lock: true, parent: grandparent) }
- context 'and the grandparent share_with_group_lock is enabled' do
- context 'when current_user owns the grandparent' do
- before do
- grandparent.add_owner(owner)
+ context 'when the grandparent share_with_group_lock is enabled' do
+ let(:grandparent) { create(:group, share_with_group_lock: true) }
+
+ context 'when the current_user owns the parent' do
+ before do
+ parent.add_owner(current_user)
+ end
+
+ context 'when the current_user owns the grandparent' do
+ before do
+ grandparent.add_owner(current_user)
+ end
+
+ it { expect_allowed(:change_share_with_group_lock) }
+ end
+
+ context 'when the current_user does not own the grandparent' do
+ it { expect_disallowed(:change_share_with_group_lock) }
+ end
end
- it { expect_allowed(:change_share_with_group_lock) }
+ context 'when the current_user does not own the parent' do
+ it { expect_disallowed(:change_share_with_group_lock) }
+ end
end
- context 'when current_user owns the parent but not the grandparent' do
- before do
- parent.add_owner(owner)
+ context 'when the grandparent share_with_group_lock is disabled' do
+ let(:grandparent) { create(:group) }
+
+ context 'when the current_user owns the parent' do
+ before do
+ parent.add_owner(current_user)
+ end
+
+ it { expect_allowed(:change_share_with_group_lock) }
end
- it { expect_disallowed(:change_share_with_group_lock) }
+ context 'when the current_user does not own the parent' do
+ it { expect_disallowed(:change_share_with_group_lock) }
+ end
end
end
- end
- context 'when the group does not have a grandparent' do
- let(:parent) { create(:group, share_with_group_lock: true) }
+ context 'when the group does not have a grandparent' do
+ let(:parent) { create(:group, share_with_group_lock: true) }
- context 'when current_user owns the parent' do
- before do
- parent.add_owner(owner)
- end
+ context 'when the current_user owns the parent' do
+ before do
+ parent.add_owner(current_user)
+ end
- it { expect_allowed(:change_share_with_group_lock) }
- end
+ it { expect_allowed(:change_share_with_group_lock) }
+ end
- context 'when current_user owns the group but not the parent' do
- it { expect_disallowed(:change_share_with_group_lock) }
+ context 'when the current_user does not own the parent' do
+ it { expect_disallowed(:change_share_with_group_lock) }
+ end
end
end
- end
- context 'when the parent share_with_group_lock is disabled' do
- let(:parent) { create(:group) }
- let(:current_user) { owner }
-
- context 'when current_user owns the parent' do
- before do
- parent.add_owner(owner)
- end
+ context 'when the parent group share_with_group_lock is disabled' do
+ let(:parent) { create(:group) }
it { expect_allowed(:change_share_with_group_lock) }
end
+ end
- context 'when current_user owns the group but not the parent' do
- it { expect_allowed(:change_share_with_group_lock) }
- end
+ context 'when the group share_with_group_lock is disabled' do
+ it { expect_allowed(:change_share_with_group_lock) }
end
end
- context 'when the group does not have a parent' do
- context 'when current_user owns the group' do
- let(:current_user) { owner }
+ context 'when the current_user does not own the group' do
+ let(:current_user) { create(:user) }
- it { expect_allowed(:change_share_with_group_lock) }
- end
+ it { expect_disallowed(:change_share_with_group_lock) }
end
end
end