diff options
author | Mayra Cabrera <mcabrera@gitlab.com> | 2018-04-04 18:43:41 -0500 |
---|---|---|
committer | Mayra Cabrera <mcabrera@gitlab.com> | 2018-04-06 21:20:16 -0500 |
commit | 171b2625b128e5954ce0a150a4fc923a22164e4e (patch) | |
tree | 834586c27477a404e71fe2fac9d17ecf3e495e58 /spec/policies | |
parent | 7deab3172257bef7818ce834c1e0709432ddd5e0 (diff) | |
download | gitlab-ce-171b2625b128e5954ce0a150a4fc923a22164e4e.tar.gz |
Addreses backend review suggestions
- Remove extra method for authorize_admin_project
- Ensure project presence
- Rename 'read_repo' to 'read_repository' to be more verbose
Diffstat (limited to 'spec/policies')
-rw-r--r-- | spec/policies/deploy_token_policy_spec.rb | 45 |
1 files changed, 45 insertions, 0 deletions
diff --git a/spec/policies/deploy_token_policy_spec.rb b/spec/policies/deploy_token_policy_spec.rb new file mode 100644 index 00000000000..cbb5fb815a1 --- /dev/null +++ b/spec/policies/deploy_token_policy_spec.rb @@ -0,0 +1,45 @@ +require 'spec_helper' + +describe DeployTokenPolicy do + let(:current_user) { create(:user) } + let(:project) { create(:project) } + let(:deploy_token) { create(:deploy_token, project: project) } + + subject { described_class.new(current_user, deploy_token) } + + describe 'creating a deploy key' do + context 'when user is master' do + before do + project.add_master(current_user) + end + + it { is_expected.to be_allowed(:create_deploy_token) } + end + + context 'when user is not master' do + before do + project.add_developer(current_user) + end + + it { is_expected.to be_disallowed(:create_deploy_token) } + end + end + + describe 'updating a deploy key' do + context 'when user is master' do + before do + project.add_master(current_user) + end + + it { is_expected.to be_allowed(:update_deploy_token) } + end + + context 'when user is not master' do + before do + project.add_developer(current_user) + end + + it { is_expected.to be_disallowed(:update_deploy_token) } + end + end +end |