summaryrefslogtreecommitdiff
path: root/spec/policies
diff options
context:
space:
mode:
authorLin Jen-Shin <godfat@godfat.org>2017-07-17 16:49:54 +0800
committerLin Jen-Shin <godfat@godfat.org>2017-07-17 16:49:54 +0800
commitc82a642b51ad9a206e97072813b64479a0a6cd4c (patch)
tree40b8b71650649efb4781840a6965a787f6b57227 /spec/policies
parent5f32bd774ad5cb89685dab5102e0614b2593d4ff (diff)
downloadgitlab-ce-c82a642b51ad9a206e97072813b64479a0a6cd4c.tar.gz
Protect manual actions against protected tag too
Diffstat (limited to 'spec/policies')
-rw-r--r--spec/policies/ci/build_policy_spec.rb25
1 files changed, 19 insertions, 6 deletions
diff --git a/spec/policies/ci/build_policy_spec.rb b/spec/policies/ci/build_policy_spec.rb
index ace95ac7067..aa62e675d37 100644
--- a/spec/policies/ci/build_policy_spec.rb
+++ b/spec/policies/ci/build_policy_spec.rb
@@ -103,12 +103,7 @@ describe Ci::BuildPolicy, :models do
project.add_developer(user)
end
- context 'when branch build is assigned to is protected' do
- before do
- create(:protected_branch, :no_one_can_push,
- name: 'some-ref', project: project)
- end
-
+ shared_examples 'protected ref' do
context 'when build is a manual action' do
let(:build) do
create(:ci_build, :manual, ref: 'some-ref', pipeline: pipeline)
@@ -130,6 +125,24 @@ describe Ci::BuildPolicy, :models do
end
end
+ context 'when build is against a protected branch' do
+ before do
+ create(:protected_branch, :no_one_can_push,
+ name: 'some-ref', project: project)
+ end
+
+ it_behaves_like 'protected ref'
+ end
+
+ context 'when build is against a protected tag' do
+ before do
+ create(:protected_tag, :no_one_can_create,
+ name: 'some-ref', project: project)
+ end
+
+ it_behaves_like 'protected ref'
+ end
+
context 'when branch build is assigned to is not protected' do
context 'when build is a manual action' do
let(:build) { create(:ci_build, :manual, pipeline: pipeline) }